FS#32627 - [xmms] MikMod plugin crashes with latest libmikmod

Attached to Project: Arch Linux
Opened by Arthur Huillet (ahuillet) - Tuesday, 13 November 2012, 13:32 GMT
Last edited by Eric Belanger (Snowman) - Friday, 16 November 2012, 19:23 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Eric Belanger (Snowman)
Architecture x86_64
Severity High
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No



Name : xmms
Version : 1.2.11-5

Name : libmikmod
Version : 3.2.0-1

XMMS segfaults immediately upon loading a module, inside MikMod_Init().
This task depends upon

Closed by  Eric Belanger (Snowman)
Friday, 16 November 2012, 19:23 GMT
Reason for closing:  Fixed
Additional comments about closing:  Jakob: thanks for the patch.
Comment by Jakob Steltner (trurl23) - Friday, 16 November 2012, 18:17 GMT
This is a problem with the driver interface from xmms to libmikmod. Driver interface seems to have changed and now there is an additional function pointer missing. This causes entry points defined in drv_xmms.c to get mixed up. Instead of xmms_IsPresent, a wrong function is being called during initialization.
This is reproducible by just playing any .mod file in xmms.

The attached patch "xmms-1.2.11-fix-mikmod-driver.patch" adds a dummy xmms_CommandLine-Function, which is inserted at the correct place in the driver interface. A cleaner way to fix this would be #ifdef'ing LIBMIKMOD_VERSION, but I couldn't find out yet, which version of libmikmod introduced this change. This patch has to be added to the list of applied patches before building.

The attached patch "PKGBUILD-add-libmikmod-patch.patch" adds the patch above to the list of applied patches in the PKGBUILD file of xmms. Also it increases pkgrel by 1 (to 6).
Comment by Arthur Huillet (ahuillet) - Friday, 16 November 2012, 18:20 GMT
I'm surprised that anyone apart from me still cares about XMMS!
Thanks for the patch.