FS#30465 - Auto partitioner - "Disk space left" variable not reset after cancel

Attached to Project: Release Engineering
Opened by Andrew Helwer (ahelwer) - Thursday, 28 June 2012, 04:18 GMT
Last edited by Gerardo Exequiel Pozzi (djgera) - Monday, 26 November 2012, 04:49 GMT
Task Type Bug Report
Category AIF
Status Closed
Assigned To Dieter Plaetinck (Dieter_be)
Architecture All
Severity Low
Priority Normal
Reported Version 2011.08.19
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

After specifying /boot and swap partition sizes in the auto partitioner, there is a bug in the / and /home partition sizing screens.

In the / partition size screen, given N MB of disk space left, if you size the / partition as X MB and hit OK to go to the /home sizing screen, it will say /home will use N-X MB as expected. However, if you then hit cancel, you will be taken back to the / sizing screen, where it says only N-X MB of disk space remains.

I encountered the bug in 2011.08.19. Looking at the 2011.10.09 release, in src/core/libs/lib-ui-interactive.sh, on line 299 variable size_left has its value subtracted by ROOT_PART_SIZE. However, size_left is not reset to its original value at the top of the loop. Pretty easy fix; record the value of size_left in a local variable before entering the loop, then reset size_left's value to the local variable at the top of the loop.
This task depends upon

Closed by  Gerardo Exequiel Pozzi (djgera)
Monday, 26 November 2012, 04:49 GMT
Reason for closing:  Deferred

Loading...