FS#27447 - [pacman] - makepkg prints out comm errors when packaging

Attached to Project: Pacman
Opened by John (graysky) - Sunday, 04 December 2011, 18:14 GMT
Last edited by Allan McRae (Allan) - Sunday, 04 December 2011, 21:28 GMT
Task Type Bug Report
Category makepkg
Status Closed
Assigned To No-one
Architecture All
Severity Medium
Priority Normal
Reported Version 4.0.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Summary and Info: The error seems to be non-critical in that the pkg gets built. I can get this to happen building any number of packages. In this example, it is expac-git.

Steps to Reproduce: download and try to build expac-git

Here is the relevant section of the attached error log showing the error. Note, this same package build fine under pacman 3 series.

==> Finished making: expac-git 20111204-1 (Sun Dec 4 13:08:47 EST 2011)
==> Cleaning up...
comm: file 1 is not in sorted order
comm: file 2 is not in sorted order
comm: file 1 is not in sorted order
comm: file 2 is not in sorted order
==> ERROR: An unknown error has occurred. Exiting...
==> Removing installed dependencies...
   error (3.5 KiB)
This task depends upon

Closed by  Allan McRae (Allan)
Sunday, 04 December 2011, 21:28 GMT
Reason for closing:  Duplicate
Additional comments about closing:   FS#27221 
Comment by John (graysky) - Sunday, 04 December 2011, 18:18 GMT
Here is another example, this time building file-roller from [extra] via ABS.


==> Leaving fakeroot environment.
==> Finished making: file-roller 3.2.2-1 (Sun Dec 4 13:17:33 EST 2011)
==> Cleaning up...
comm: file 1 is not in sorted order
comm: file 2 is not in sorted order
comm: file 1 is not in sorted order
comm: file 2 is not in sorted order
==> ERROR: An unknown error has occurred. Exiting...
==> Removing installed dependencies...
checking dependencies...
Comment by Karol Błażewicz (karol) - Sunday, 04 December 2011, 19:03 GMT
I've just built expac-git with pacman 4.0.1-1 & 'makepkg -src' - no errors.


Edit: The errors occurs only when you've installed some dependencies along the way. If e.g. I remove git prior to running 'makepkg -src' I get the same error.
Comment by Karol Błażewicz (karol) - Sunday, 04 December 2011, 19:15 GMT
--- /usr/bin/makepkg 2011-12-04 19:12:27.000000000 +0000
+++ /usr/bin/makepkg1 2011-12-04 19:12:00.000000000 +0000
@@ -506,14 +506,14 @@

# check for packages removed during dependency install (e.g. due to conflicts)
# removing all installed packages is risky in this case
- if [[ -n $(comm -23 <(printf "%s\n" "${original_pkglist[@]}") \
- <(printf "%s\n" "${current_pkglist[@]}")) ]]; then
+ if [[ -n $(comm -23 <(printf "%s\n" "${original_pkglist[@]}"|sort) \
+ <(printf "%s\n" "${current_pkglist[@]}"|sort)) ]]; then
warning "$(gettext "Failed to remove installed dependencies.")"
return 0
fi

- local deplist=($(comm -13 <(printf "%s\n" "${original_pkglist[@]}") \
- <(printf "%s\n" "${current_pkglist[@]}")))
+ local deplist=($(comm -13 <(printf "%s\n" "${original_pkglist[@]}"|sort) \
+ <(printf "%s\n" "${current_pkglist[@]}"|sort)))
(( ${#deplist[@]} == 0 )) && return

msg "Removing installed dependencies..."


Seems to get rid of the errors but I don't know if this is the Right Way (tm) to do it.
Comment by John (graysky) - Sunday, 04 December 2011, 20:22 GMT
Glad someone was able to reproduce ;)
Comment by Ionut Biru (wonder) - Sunday, 04 December 2011, 21:38 GMT
it works for me
Comment by Karol Błażewicz (karol) - Sunday, 04 December 2011, 21:43 GMT
If it's a duplicate, why are people able to add comments? It should be closed and I think it has been closed by Allan but wonder broke it ;P
Comment by Allan McRae (Allan) - Sunday, 04 December 2011, 22:07 GMT
The pacman section allow comments after closure...

Loading...