FS#24998 - makepkg: distcc should have its own MAKEFLAGS

Attached to Project: Pacman
Opened by Mark (voidzero) - Sunday, 03 July 2011, 11:46 GMT
Last edited by Dan McGee (toofishes) - Monday, 22 August 2011, 16:40 GMT
Task Type Bug Report
Category General
Status Closed
Assigned To Dan McGee (toofishes)
Architecture All
Severity Medium
Priority Normal
Reported Version 3.5.3
Due in Version 4.0.0
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

/etc/makepkg.conf contains a MAKEFLAGS line. Currently it is unset by makepkg if distcc is not set or found:

/usr/bin/makepkg
815 run_build() {
816 # use distcc if it is requested (check buildenv and PKGBUILD opts)
817 if [[ $(check_buildenv distcc) = "y" && $(check_option distcc) != "n" ]]; then
818 [[ -d /usr/lib/distcc/bin ]] && export PATH="/usr/lib/distcc/bin:$PATH"
819 export DISTCC_HOSTS
820 elif [[ $(check_option distcc) = "n" ]]; then
821 # if it is not wanted, clear the makeflags too
822 MAKEFLAGS=""
823 fi
...

This is far from optimal since most recent PCs have multicore processors.

Adviced solution:
Do not unset MAKEFLAGS but rather create a new variable in /etc/makepkg.conf called DISTCC_MAKEFLAGS. If DISTCC_MAKEFLAGS and distcc have been set, do MAKEFLAGS=$DISTCC_MAKEFLAGS, otherwise don't touch it.

This also needs a notice in makepkg.conf.

(Now I know why MAKEFLAGS always seemed to be ignored... I don't use distcc :))
This task depends upon

Closed by  Dan McGee (toofishes)
Monday, 22 August 2011, 16:40 GMT
Reason for closing:  Implemented
Additional comments about closing:  settings are no longer linked, but we don't think we need a second variable
Comment by Allan McRae (Allan) - Sunday, 03 July 2011, 12:04 GMT
FYI: http://projects.archlinux.org/pacman.git/commit/?id=aa89a65a
Comment by Mark (voidzero) - Sunday, 03 July 2011, 13:25 GMT
Ah, did not see that, thank you for linkage. Well, my idea is a little improvement over that -- in my example one could use two different sets of MAKEFLAGS and only enable/disable distcc rather than changing MAKEFLAGS /and/ distcc every time. Implementing is easy but if it does not carry the same necessity for everyone feel free to close this bug.

Loading...