FS#23960 - [pacman] add double quotes in PKGBUILD man page example

Attached to Project: Pacman
Opened by Marcel Korpel (Marcel-) - Wednesday, 27 April 2011, 10:16 GMT
Last edited by Allan McRae (Allan) - Monday, 02 May 2011, 23:47 GMT
Task Type Bug Report
Category Documentation
Status Closed
Assigned To No-one
Architecture All
Severity Low
Priority Normal
Reported Version 3.5.1
Due in Version 3.5.3
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

In PKGBUILD's man page /usr/share/man/man5/PKGBUILD.5.gz there's an example of for the patch package. In this example, $srcdir and $pkgdir are used without surrounding double quotes. This could cause errors when running makepkg, as $srcdir and $pkgdir might contain spaces in directory names.

In this example, correct spelling would be:

cd "$srcdir/$pkgname-$pkgver"
[…]
make prefix="$pkgdir/usr" install

Additional info:
* package version(s): pacman 3.5.2-1
This task depends upon

Closed by  Allan McRae (Allan)
Monday, 02 May 2011, 23:47 GMT
Reason for closing:  Implemented
Additional comments about closing:  http://projects.archlinux.org/pacman.git /commit/?h=maint&id=9a127d8e
Comment by Allan McRae (Allan) - Monday, 02 May 2011, 00:33 GMT
Patch on my working branch

Loading...