FS#19488 - makepkg doesn't set +r on .INSTALL

Attached to Project: Pacman
Opened by Gavin Bisesi (Daenyth) - Monday, 17 May 2010, 00:45 GMT
Last edited by Allan McRae (Allan) - Wednesday, 26 May 2010, 10:53 GMT
Task Type Bug Report
Category General
Status Closed
Assigned To Allan McRae (Allan)
Architecture All
Severity Low
Priority Normal
Reported Version 3.3.3
Due in Version 3.4.0
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

If you build a package with umask 077, the .INSTALL file is generated without +r. Probably the best way is to just chmod 0644 .INSTALL before compressing.
This task depends upon

Closed by  Allan McRae (Allan)
Wednesday, 26 May 2010, 10:53 GMT
Reason for closing:  Implemented
Additional comments about closing:  http://projects.archlinux.org/pacman.git /commit/?id=3cd237de
Comment by Allan McRae (Allan) - Monday, 17 May 2010, 06:19 GMT
Does this matter in any way? The package appears to still install with the correct permissions on the install file.
Comment by Gavin Bisesi (Daenyth) - Monday, 17 May 2010, 13:06 GMT
Namcap reports it as an error in the package file. If it doesn't matter it probably would be better then to change namcap.
Comment by Dan McGee (toofishes) - Monday, 17 May 2010, 14:59 GMT
We should probably just chmod any metadata files to 644 as a matter of just being consistent. I don't see this being any sort of release blocker though, and patches are welcome of course.
Comment by Gavin Bisesi (Daenyth) - Monday, 17 May 2010, 22:09 GMT
I can probably put in a patch for it without too much trouble. Will look at it later... Feel free to assign ticket to me if flyspray lets you.
Comment by Allan McRae (Allan) - Tuesday, 18 May 2010, 11:20 GMT
Can not assigned to you, but is should be a two line patch (one chmod for the .INSTALL file, and one for the .CHANGELOG file).
Comment by Gavin Bisesi (Daenyth) - Tuesday, 18 May 2010, 12:18 GMT
Yeah, I just have a feeling I'll forget if it isn't. Will try not to. :P
Comment by Allan McRae (Allan) - Saturday, 22 May 2010, 12:31 GMT
patch: http://mailman.archlinux.org/pipermail/pacman-dev/2010-May/010854.html

Loading...