FS#19313 - [ifplugd] ifplugd.action script is not really a /bin/sh script

Attached to Project: Arch Linux
Opened by Benoit Izac (benizac) - Saturday, 01 May 2010, 13:41 GMT
Last edited by Dave Reisner (falconindy) - Saturday, 28 April 2012, 18:54 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Thomas Bächler (brain0)
Dave Reisner (falconindy)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 3
Private No

Details

/etc/ifplugd/ifplugd.action shebang is /bin/sh but the script include /etc/rc.con and /etc/rc.d/functions which have bash syntax.
The shebang should be
#!/bin/bash
insteed of
#!/bin/sh
This task depends upon

Closed by  Dave Reisner (falconindy)
Saturday, 28 April 2012, 18:54 GMT
Reason for closing:  Fixed
Additional comments about closing:  extra/ifplugd-0.28-10
Comment by Dave Reisner (falconindy) - Saturday, 19 February 2011, 23:30 GMT
Took this opportunity to clean the hell out of the /etc/rc.d/ifplugd script. Any testing you can do would be appreciated.
   ifplugd (2 KiB)
   ifplugd.action (0.5 KiB)
Comment by Walter Sullivan (wajasu) - Thursday, 12 January 2012, 19:44 GMT
I was using the net-auto-wired netcfg script and noticed in /var/log/messages the illegal syntax token messages. I saw that the syntax was indeed bash syntax in /etc/rc.d/functions which was "sourced". I installed and tested the the above attached ifplugd.action, as well as ifplugd, and both work wonderfully. Now when I plug in my ethernet, things work cleanly, and the "unmount_all" function that is now in the latest core/initscripts 2012.01.2-1 won't have a syntax error reported.

Comment by Allan McRae (Allan) - Saturday, 28 April 2012, 13:15 GMT
@Dave: are you going to push these changes?
Comment by Dave Reisner (falconindy) - Saturday, 28 April 2012, 14:29 GMT
Sure, I'll clean this up.

Loading...