FS#18988 - Allow to specify directory name in NoExtract option in pacman.conf

Attached to Project: Pacman
Opened by Sergej Pupykin (sergej) - Wednesday, 07 April 2010, 16:40 GMT
Last edited by Dave Reisner (falconindy) - Sunday, 13 November 2011, 19:46 GMT
Task Type Feature Request
Category Backend/Core
Status Closed
Assigned To Dan McGee (toofishes)
Allan McRae (Allan)
Dave Reisner (falconindy)
Architecture All
Severity Low
Priority Normal
Reported Version 3.3.3
Due in Version 4.1.0
Due Date Undecided
Percent Complete 100%
Votes 6
Private No

Details

Here is 2 (not perfect, probably even dirty, but they work) patches to compare file names by prefix.

So user can set NoExtract = usr/share/man to disable all man pages installing.
   0001-NoExtract-by-directory-n... (1.9 KiB)
   0002-NoExtract-by-directory-n... (0.7 KiB)
This task depends upon

Closed by  Dave Reisner (falconindy)
Sunday, 13 November 2011, 19:46 GMT
Reason for closing:  Implemented
Additional comments about closing:  see comments
Comment by Dan McGee (toofishes) - Wednesday, 05 May 2010, 04:04 GMT
Sorry for this getting lost for a while. Allan, what do you think about this? I'd do it slightly differently (not try and cram another function into alpm_list.c/h and just do the find with the function directly) but otherwise I don't know that I can think of any huge drawbacks. It also needs documentation, of course.
Comment by Allan McRae (Allan) - Wednesday, 05 May 2010, 05:34 GMT
I like the idea. It would allow those who would like makepkg's '!docs' to be enabled to have the functional equivalant even when their distro incudes the docs. A younger version of me would have also used it for info and man pages...
Comment by Green (The_Green_Arrow) - Friday, 13 August 2010, 20:15 GMT
Why not using bash glob expansion ?
For example :
IgnorePkg=usr/share/man/* will be converted at runtime in an array containing all the files...
It could even handle regular expression.
What do you think ?

Comment by JM (fijam) - Tuesday, 17 August 2010, 11:22 GMT
I am running arch on a thin client with a small DiskOnModule drive and would very much like to see it implemented.
Comment by Sergej Pupykin (sergej) - Tuesday, 13 September 2011, 10:04 GMT
Cleaned up and updated to current git patch is in attachment. Please review it.
   0001-FS-18988-Allow-to-specif... (2.4 KiB)
Comment by Sergej Pupykin (sergej) - Tuesday, 13 September 2011, 10:11 GMT
I can not do anything clean on first attempt :)

!memcmp(path, file, path_len) && (path_len < file_len)

should be swapped

(path_len < file_len) && !memcmp(path, file, path_len)

to avoid crash. Or even split into different if operators.
Comment by Sergej Pupykin (sergej) - Tuesday, 13 September 2011, 10:22 GMT
looks working for me
   0001-FS-18988-Allow-to-specif... (2.4 KiB)
Comment by Sergej Pupykin (sergej) - Tuesday, 13 September 2011, 10:47 GMT
Added prototype to alpm_list.h and replace memcmp to strncmp.
   0001-FS-18988-Allow-to-specif... (3 KiB)
Comment by Dave Reisner (falconindy) - Sunday, 13 November 2011, 19:46 GMT
Implemented:

http://projects.archlinux.org/pacman.git/commit/?id=902305f1633298ff0ef7cd2bfbed0e91aae91646

Loading...