FS#18796 - [dbus-core] 1.2.22 does not successfully suspend/resume

Attached to Project: Arch Linux
Opened by Ng Oon-Ee (ngoonee) - Tuesday, 23 March 2010, 01:23 GMT
Last edited by Jan de Groot (JGC) - Wednesday, 24 March 2010, 21:31 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Jan de Groot (JGC)
Architecture x86_64
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 5
Private No

Details

Description:
On upgrading dbus/dbus-core from 1.2.20-1 to 1.2.22-1, suspend appears to succeed but on resume dbus is dead. Gnome works, but a lot of the IPC-related stuff breaks down, for example the panel icons stop working, clicking 'Quitter' in cairo-dock which normally brings up the gnome power-selection dialog (restart, shut down, sleep, hibernate) automatically shuts down the system.

Error message as indicated below. I can confirm that /var/run/dbus/system_bus_socket exists, and ls -la shows it to have full permissions for everyone, and owned by root:root

Additional info:
* package version(s)
dbus 1.2.22-1 and dbus-core 1.2.22-1
* config and/or log files etc.
Don't have the full one, but get this in /var/log/pm-suspend.log
libhal_ctx_set_dbus_connection: org.freedesktop.DBus.Error.NoServer: Failed to connect to socket /var/run/dbus/system_bus_socket

Steps to reproduce:
1. Upgrade dbus/dbus-core
2. Suspend
3. Resume
This task depends upon

Closed by  Jan de Groot (JGC)
Wednesday, 24 March 2010, 21:31 GMT
Reason for closing:  Fixed
Additional comments about closing:  1.2.24 is in core.
Comment by Ubermensch (Ubermensch) - Tuesday, 23 March 2010, 18:10 GMT
I have the same problem with dbus 1.2.22-1 and dbus-core 1.2.22-1. When I try to disable the Wi-Fi with network-manager gdm crashes e i can not activate hal, dbus and gdm.
Comment by Ionut Biru (wonder) - Tuesday, 23 March 2010, 21:37 GMT
please test this patch: http://cgit.freedesktop.org/dbus/dbus/commit/?h=dbus-1.2&id=c4371e4bc8a561cf91516d22f00c9512dc7e8e53

apply it to dbus-core and report back
Comment by Ng Oon-Ee (ngoonee) - Tuesday, 23 March 2010, 22:54 GMT
Patch fixes things for me.
Comment by Ubermensch (Ubermensch) - Tuesday, 23 March 2010, 22:57 GMT
How doi apply??
Comment by Ng Oon-Ee (ngoonee) - Tuesday, 23 March 2010, 23:01 GMT
@Ubermensch, the patch didn't patch cleanly for me as well.

What you can do is get the PKGBUILD from abs/svn (abs would not have the current I think), and add these sed lines I used. Add them after the line which says cd "${srcdir}/dbus-${pkgver}"

cd bus/
cat bus.c | sed 's/_dbus_system_log (severity, "%s", full_msg)\;/_dbus_system_log (severity, "%s", _dbus_string_get_const_data (\&full_msg))\;/' > tmp
mv tmp bus.c
cd ..
Comment by Ionut Biru (wonder) - Tuesday, 23 March 2010, 23:14 GMT
add to sources:

test.patch::http://cgit.freedesktop.org/dbus/dbus/patch/?id=c4371e4bc8a561cf91516d22f00c9512dc7e8e53

after $srcdir/dbus-$pkgver add
patch -Np1 -i $srcdir/test.patch

save, makepkg -g >> PKGBUILD and then makepkg.
Comment by Ubermensch (Ubermensch) - Wednesday, 24 March 2010, 11:14 GMT
Perfect I solved the problem. Thanks!!!
Comment by Andrew Munkres (amunkres) - Wednesday, 24 March 2010, 11:32 GMT
It looks like this same bug may be also causing the problems mentioned in this forum thread: http://bbs.archlinux.org/viewtopic.php?id=93742

(As mentioned there, when using dbus 1.2.22-1 and KDE, the "/usr/bin/dbus-daemon --system" instance of dbus crashes immediately after KDE starts.)
Comment by Jan de Groot (JGC) - Wednesday, 24 March 2010, 18:05 GMT
This is fixed in dbus-core 1.2.24 which is in testing at this moment. If anyone confirms it fixes this bug and doesn't break further things, I'd like to move it to core.
Comment by Andrew Munkres (amunkres) - Wednesday, 24 March 2010, 21:21 GMT
1.2.24 seems to work ok for me.

Loading...