Arch Linux

Description:
If a game of snooker ends in a draw (This can only happen in snooker), the game stays in an invalid state. If AI players are in the game, they might try to hole the cue ball, but the game itself will never end. This can be an issue preventing a tournament from finishing.


Additional info:
* package version(s) 3.0a-5
* config and/or log files etc.


Steps to reproduce:
$ foobillard --snooker --gamemode tournament
Wait for a game to end up in a draw (This might take a very long time, since the odds to draw are very low. You might want to modify the code to have it happen faster. See patch below.)
Note how the game can no longer move on without restarting the whole tournament.
To force a draw in a game, simply remove all points awarded or resulting from opponent's fouls:
Index: src/evaluate_move.c
===================================================================
--- src/evaluate_move.c (revision 6)
+++ src/evaluate_move.c (working copy)
@@ -555,12 +555,12 @@
if(foul)
{
act_penalty =MAX(act_penalty,4);
- player[other_player].score += act_penalty ;
+ //player[other_player].score += act_penalty ;
printf("EVAL foul\n");
}
else
{
- player[act_player].score += act_score ;
+ //player[act_player].score += act_score ;
printf("EVAL no foul\n");
textObj_setText(last_fault_text, "x");
}