FS#15907 - Options for filesystem : can't use '^' to disable one ?

Attached to Project: Release Engineering
Opened by maxi jac (maxi_jac) - Tuesday, 11 August 2009, 16:28 GMT
Last edited by Dieter Plaetinck (Dieter_be) - Sunday, 18 April 2010, 17:48 GMT
Task Type Bug Report
Category AIF
Status Closed
Assigned To Gerhard Brauer (GerBra)
Dieter Plaetinck (Dieter_be)
Architecture All
Severity Medium
Priority Normal
Reported Version 2009.08
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

I don't know if it is more of a feature request or a bug.
Using archinstaller i686 core
When setting filesystems, at the opts question, I tried to give it "^has_journal" (in order to have a /boot ext4 without journal) but I checked after filesystem was created and it had the has_journal feature.

I had to manually umount it, format it with my options (mke2fs -t ext4 -O ^has_journal) and remount it to /mnt/boot
This task depends upon

Closed by  Dieter Plaetinck (Dieter_be)
Sunday, 18 April 2010, 17:48 GMT
Reason for closing:  Fixed
Comment by Gerhard Brauer (GerBra) - Tuesday, 11 August 2009, 17:50 GMT
Confirmed.

BTW: the correct Syntax to put the option into the dialog were: -O ĥas_journal (cause -O is one possible parameter of mkfs.ext4).

But we have a general bug in:
process_filesystem ()
Comment by Gerhard Brauer (GerBra) - Tuesday, 11 August 2009, 19:00 GMT
Ok, i attach a diff to show were the main error occurs.
But this is not enough. We also get problems on supplied options from function: interactive_filesystem ():
fs_opts=$(sed 's/ /_/g' <<< "$ANSWER_STRING") #TODO: clean up all whitespace (tabs and shit)
If i disable this sed'ing we run into the next problem during mkfs:
With this special option "-O ĥas_journal" as $fs_opts is only take the first word (here: "-O").
We have to masq all occurences of $fs_opts with "$fs_opts".
Reason: filesystem options could have whitespaces.

I'm not sure with the change from $opts to $fs_opts on dm_crypt FS !!!

   fsopts.diff (2.7 KiB)
Comment by Dieter Plaetinck (Dieter_be) - Tuesday, 11 August 2009, 19:07 GMT
Gerhard, don't put to much work in fixing this for now. There are some known issues there (see various todo's in that function)
Some of which are handled by Matthias Dienstbier, whose patches i still need to merge in.
After i merged in his patches we could work further on this.

I also clarified the 'use complete option' thing in the installation guide. http://projects.archlinux.org/?p=aif.git;a=commitdiff;h=2ef92eaa5f1106d8f1b379a8a94a477a0877bb1f;hp=bf1ea974307c41bdc286f0ee220a97c7462ee1b8
Comment by Dieter Plaetinck (Dieter_be) - Sunday, 18 April 2010, 17:48 GMT
okay there were some bugs in this code, Gerhards diff was already a good direction, anyway this is fixed: http://bugs.archlinux.org/task/18994

since '^' has a special meaning for sed however, i verified this myself, and i can confirm that for an ext4 if you pass -O ^has_journal, it has no journal

Loading...