Arch Linux

this (or at least a very similar problem) is still the case with the latest code in git.
if it downloads packages, and while doing so you do `dhcpcd -k eth0` pacman will exit(1) with a bunch of errors, but aif will say 'package installation complete'
see http://bugs.archlinux.org/task/16277

i thought it was fixed because of http://projects.archlinux.org/aif.git/commit/?id=a6769ebf0338188a44a260d99f024bf2bf954a44, but i guess not.

Okay, I did some debugging and found there are a whole bunch of different cases:

1) disable network before package selection
-> you will get an error that it failed, titled 'Pacman preparation failure'. this is good (and the only working case)

2) disable network after the package groups selection comes up
-> the database is synced, it is able to fetch the list of packages, but not install them
3) disable network before the actual installation of packages
-> this is basically the same as #2
the result is here that pacman logs the errors, but says "package installation complete". It does exit(1) and aif shows a "continue" button. So both pacman and aif require some fixing.
See:  FS#22035  - Pacman says "package installation complete" on connection refused

4) mirror times out:
-> pacman will just hang and not exit, keeping aif (and the user) waiting.
 FS#15369  - Pacman should timeout when mirror is not responding

5) make the disk too small so the disk gets full during package installation.
-> result: pacman has a bunch of errors, but says "package installation complete" and exits(0), which is bad.
 FS#22034  - Pacman ignores disk full errors and exit(0) at the end

I just fixed the bugs which caused AIF to ignore the pacman exit code. This also fixed another mkinitcpio call. so when pacman exits >0, aif will now tell you the failure, show the pacman logfile, and mark the step as unsuccessful.

Now we just need to get those 3 pacman bugs fixed :)