FS#15263 - [initscripts] Avoid changing users hardwareclock if settings not clear

Attached to Project: Arch Linux
Opened by Gerhard Brauer (GerBra) - Thursday, 25 June 2009, 17:07 GMT
Last edited by Aaron Griffin (phrakture) - Friday, 26 June 2009, 18:52 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Aaron Griffin (phrakture)
Thomas Bächler (brain0)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:
Currently in rc.shutdown we assume that HARDWARECLOCK is on localtime when UTC is not especially set. And so we change BIOS-Clock on shutdown.
But i see a problem with this on our install ISOs: /etc/rc.conf HARDWARECLOCK value there is set via cmdline parameter - or even not when no parameter (that's default)
If one now has UTC time as BIOS-Time (and select this and TZ correctly in installer), then during shutdown his UTC BIOS time is overwritten with --systohc --localtime.
Next boot this will leed to a false datetime.

Also i think: we should keep hands off from users BIOS clock if we're not absolutely sure that we could set a correct value. So we should fix this not only in ISO/installer, but also in our general rc.shutdown.

I made a patch vor initscripts->rc.shutdown to avoid this.

   rc.shutdown.patch (0.6 KiB)
This task depends upon

Closed by  Aaron Griffin (phrakture)
Friday, 26 June 2009, 18:52 GMT
Reason for closing:  Implemented
Additional comments about closing:  Added to git
Comment by Aaron Griffin (phrakture) - Friday, 26 June 2009, 17:54 GMT
Pushed to git, thanks
http://projects.archlinux.org/?p=initscripts.git;a=commit;h=92cbc62e1c1b22c6cc251628e8d51a45607998b6
Comment by Dieter Plaetinck (Dieter_be) - Friday, 26 June 2009, 18:32 GMT
Gerhard is the best! ;-)
Comment by Gerhard Brauer (GerBra) - Friday, 26 June 2009, 18:45 GMT
Huh! What have i done...
Please close ASAP, i couldn't slip in my clothes anymore when i read this often ;-)

Loading...