FS#15142 - offer to clean up non-package files in cache directory

Attached to Project: Pacman
Opened by Allan McRae (Allan) - Wednesday, 17 June 2009, 07:54 GMT
Last edited by Dan McGee (toofishes) - Thursday, 16 July 2009, 11:18 GMT
Task Type Feature Request
Category General
Status Closed
Assigned To Xavier (shining)
Architecture All
Severity Low
Priority Normal
Reported Version 3.2.2
Due in Version 3.3.0
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Summary and Info:
Pacman recognises that a file in the cache directory is not an archive so should offer to clean it up.

> pacman -Sc
Cache directory: /var/cache/pacman/pkg/
Do you want to remove outdated packages from cache? [Y/n]
removing old packages from cache... error: error while reading package /var/cache/pacman/pkg/gnome-do-plugins-0.8.1.3-1.pkg.tar.gz.part: Unrecognized archive format
done.
This task depends upon

Closed by  Dan McGee (toofishes)
Thursday, 16 July 2009, 11:18 GMT
Reason for closing:  Fixed
Additional comments about closing:  Commit 8ebc07744ac58ed1e42af3a52d9985
Comment by Xavier (shining) - Wednesday, 08 July 2009, 12:02 GMT
Is this ok?

myhost% sudo src/pacman/pacman -Sc
Cache directory: /var/cache/pacman/pkg/
Do you want to remove uninstalled packages from cache? [Y/n]
removing old packages from cache...
error: missing package metadata in /var/cache/pacman/pkg/aaaaaaa
File /var/cache/pacman/pkg/aaaaaaa does not seem to be a valid package, remove it? [Y/n]

Database directory: /var/lib/pacman/
Do you want to remove unused repositories? [Y/n]
Database directory cleaned up

   0002-Offer-to-clean-up-non-pa... (2.4 KiB)
Comment by Allan McRae (Allan) - Wednesday, 08 July 2009, 12:07 GMT
Looks good to me.
Comment by Dan McGee (toofishes) - Thursday, 16 July 2009, 04:42 GMT
So the second "all" note should really read "all files" and not "all packages", right? Otherwise this seems like something we can get into 3.3.
Comment by Xavier (shining) - Thursday, 16 July 2009, 06:34 GMT
yeah probably these two messages should always have been "all files" :

if(!noyes(_("Do you want to remove ALL packages from cache?"))) {
printf(_("removing all packages from cache...\n"));

I will change that and put on my working branch.

Loading...