Arch Linux

I don't see the problem. If you choose a other IP than the default (with an other subnet) then you must also change the - default - broadcast address. The installer doesn't do that automatically for you.
And when all values for your network are correct in network setup dialog then these values are also correct in generated rc.conf.
I've made all my tests with an 10.0.0.X IP and settings and see never a problem.

Sorry, there's a mistake in that patch, this one does work.

This is the problem:

In line 884 of the setup script there is: sed -i "s#192.168.0.2# $IPADDR#g" ${DESTDIR}/etc/rc.conf

Which means that it will replace 192.168.0.2 by the IP address you choose. The problem is that the line 62 in the default rc.conf is:

eth0="eth0 192.168.0.2 netmask 255.255.255.0 broadcast 192.168.0.255"

So if you choosed 192.168.0.27 (for example) it will end up looking like this:

eth0="eth0 192.168.0.27 netmask 255.255.255.0 broadcast 192.168.0.2755"

If you take a look at the broadcast IP it is clearly invalid.

To clarify, the sed line that should replace the default broadcast IP with the one you choosed (line 886) looks for 192.168.0.255 in rc.conf and won't find it.

looks like there are 2 problems here:
- the sed for the ip does a global replace and since the broadcast contains the ip-string it will also replace there, updating the broadcast in rc.conf to something incorrect
- the sed that should fix the broadcast cannot find what it's looking for, because the previous thing.

your solution fixes both and looks good to me. let's use it for the next release

Out of curiosity, do we need the final quote in the broadcast sed expression? It makes it ugly, and breaks the expression with a simply space or any addition after that entry.

Good point. Imho we don't need it. let's leave it out (the characters \# ) for both the regex and the replacement part.

ported to aif. http://github.com/Dieterbe/aif/commit/39e42a15a8e1c5ea1b4a61874de4f4834cb64e68

That's right, the final quote is not needed as "broadcast" does not appear more times in rc.conf.

I left in case it could appear more times because it was already there.

Implemented in aif. all that's needed right now is testing :)

I'm sorry to answer so late, I've been in hospital for some time and I wont be able to perform tests and so right now. I need some time to rest and recover but I'll be back as soon as possible.

Anyway I've taken a look to the code in AIF (lib-network.sh) and it should work, I can't see anything wrong there. The code already worked with the old installer and in AIF it is essentially the same.

Regards.

that's okay. good luck with the recovery and all.

Seems fixed at last in 2009.08-beta1.
Tested with IP 192.168.xxx.201, broadcast was correctly set. All values during manual network config are correctly parsed to generated rc.conf.