FS#11814 - setup makes wrong entry on mirror choosing

Attached to Project: Release Engineering
Opened by Tobias Powalowski (tpowa) - Monday, 20 October 2008, 16:46 GMT
Last edited by Aaron Griffin (phrakture) - Tuesday, 27 January 2009, 04:45 GMT
Task Type Bug Report
Category Installation
Status Closed
Assigned To Tobias Powalowski (tpowa)
Simo Leone (neotuli)
Aaron Griffin (phrakture)
Dan McGee (toofishes)
Dieter Plaetinck (Dieter_be)
Architecture All
Severity Low
Priority Normal
Reported Version None
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

wrong part:
1370 PAC_SYNC_SERVER="$(cat $ANSWER)"
1371 if [ "$PAC_SYNC_SERVER" = "Custom" ]; then
1372 DIALOG --inputbox "Enter the full URL to packages, for example:\nhttp://server.org/archlinux/\$repo/os/i686" 8 65 "http://" 2>$ANSWER || return 1
1373 PAC_SYNC_SERVER="$(cat $ANSWER)"
1374 fi
1375 else
1376 PAC_SYNC_SERVER="${SYNC_URL}"
1377 fi
1378 # comment out all existing mirrors
1379 sed -i -e 's/^Server/#Server/g' "$mirrorlist"
1380 # add our new entry at the end of the file
1381 echo "# Setup-configured entry" >> "$mirrorlist"
1382 echo Server = $PAC_SYNC_SERVER >> "$mirrorlist"
1383 # NOTE: no call to ${EDITOR} for this 'file'

proposed correction, it's propably not 100% fitting to normal setup:
PAC_SYNC_SERVER="$(cat $ANSWER)"
if [ "$PAC_SYNC_SERVER" = "Custom" ]; then
DIALOG --inputbox "Enter the full URL to packages, for example:\nhttp://server.org/archlinux/\$repo/os/$(uname -m)" 8 65 "http://" 2>$ANSWER || return 1
PAC_SYNC_SERVER="$(cat $ANSWER)"
fi
else
PAC_SYNC_SERVER="$(echo ${SYNC_URL} | sed 's/core/\$repo/g')"
fi
# comment out all existing mirrors
sed -i -e 's/^Server/#Server/g' "$mirrorlist"
# add our new entry at the end of the file
echo "# Setup-configured entry" >> "$mirrorlist"
echo Server = $(egrep -o "$PAC_SYNC_SERVER.*" "$mirrorlist") >> "$mirrorlist"
This task depends upon

Closed by  Aaron Griffin (phrakture)
Tuesday, 27 January 2009, 04:45 GMT
Reason for closing:  Duplicate
Additional comments about closing:   FS#12944  fixes this issue
Comment by Dan McGee (toofishes) - Thursday, 23 October 2008, 06:05 GMT
Should be fixed with the attached patch.
Comment by Aaron Griffin (phrakture) - Thursday, 30 October 2008, 21:46 GMT
Is this in git? Closable?
Comment by Glenn Matthys (RedShift) - Friday, 05 December 2008, 14:53 GMT
What's the status of this issue?
Comment by Dieter Plaetinck (Dieter_be) - Monday, 26 January 2009, 20:21 GMT
What exactly is this about? having hardcoded <mirrorname>/core/<blah> instead of <mirrorname>/$repo/<blah> in the mirrorlist?
If so, then it's the same issue as http://bugs.archlinux.org/task/12944?project=6

Loading...