Arch Linux

A unified diff would be easier to read. diff -ruN oldfile newfile > difffile

Well I thought about posting a patch, but this script is simple enough.
Also I didn't know against which version I should diff, the newer cvs one or the older svn one.

Well, actually the only difference between cvs and svn was a little update on that bash_completion.sh file.
http://repos.archlinux.org/viewvc.cgi/extra/system/bash-completion/bash_completion.sh?root=extra&r1=1.6&r2=1.7
So I just based the diff against the svn version, and included the "remove unnecessary bash version checking" change.

Besides the shopt -q login_shell change, I made a second one too :
http://bbs.archlinux.org/viewtopic.php?pid=405760#p405760

It seems better to use $BASH_VERSION rather than $SHELL for checking that the shell is bash.
And the upstream script does it that way.

Great, when using gdm, it seems like at no point a login shell is launched, so the above patch won't work. That's pure genius.
It can be worked around by making each terminal run a login shell.

A better alternative might be to kill this bash_completion.sh script altogether, and stop worrying about it.
We could optionally add a scriptlet telling the user how to enable it : echo "source /etc/bash_completion" >> ~/.bashrc

This change is now in testing (bash-completion 1.0)

The shopt -q login_shell test only checks for login shells, not for interactive shells. My vcN console shells are login shells, but my urxvt shells in X default to being merely interactive shells. Also, if inside a terminal I just type "bash", to get a child shell, this will again be an interactive shell and not a login shell. The current /etc/profile.d/bash_completion.sh script will ignore all of these interactive-but-not-login shells, and so I won't have any bash completion. To workaround, I need to either sourch /etc/bash_completion myself in .bashrc, as a preceding comment proposes---but that obviates the whole point of having /etc/profile.d/bash_completion.sh. Or I have to revert the bash_completion.sh script to checking [ -n "$PS1" ] or some similar test (could for example check that $- includes 'i'), instead of shopt -q login_shell. I propose we do that.

Also, konsole and yakuake do not create login shells. So effectively bash_completion stopped working completely in KDE.
What is wrong with PS1 method? Maybe there is another method, that wouldn't break all Gnome and KDE installations while fixing "some cases"? ;)

Well, I actually don't really understand.
isn't /etc/profile.d/bash_completion.sh only read when /etc/profile is sourced anyway ? And isn't /etc/profile only source in logging shells ?

So I guess this /etc/profile.d/bash_completion.sh is just useless and needs to be removed.

I also already wrote my opinion about this :
--------------
A better alternative might be to kill this bash_completion.sh script altogether, and stop worrying about it.
We could optionally add a scriptlet telling the user how to enable it : echo "source /etc/bash_completion" >> ~/.bashrc"
--------------

and it is also how the upstream page (http://bash-completion.alioth.debian.org/) says to enable it :
append the following to /etc/bashrc or ~/.bashrc :
--------------
you need to source it from either /etc/bashrc or ~/.bashrc. If you have bash >= 2.04, you just do it with:

# Use bash-completion, if available
if [ -f /etc/bash_completion ]; then
. /etc/bash_completion
fi
--------------

I also updated the wiki with that information :
http://wiki.archlinux.org/index.php?title=Bash&diff=75274&oldid=69317

> isn't /etc/profile.d/bash_completion.sh only read when /etc/profile is sourced anyway?
That seems to be true.

> And isn't /etc/profile only source in logging shells ?
That seems not to be true. In any case, reverting to the old $PS1-based test results in my non-login shells sourcing bash_completion.sh without its needing to be in my ~/.bashrc.

Eliminating the /etc/profile sourcing is no great hardship. It's just confusing that it should be there but be implemented in a way that ignores many terminal setups.

Removing /etc/profile.d/bash_completion is NOT a good idea at all. We just screwed up the implementation for non-login shells.

I will revamp this soon

I am quite happy with the situation now.
/etc/bash.bashrc just sources /etc/bash_completion
and in the future ( FS#16346 ), /etc/profile.bash will source /etc/bash.bashrc
so all bases will be covered, in a more elegant way (imo).