FS#28307 - [makepkg] hg pull now returns 1 if no changes were found

Attached to Project: Pacman
Opened by Gaetan Bisson (vesath) - Tuesday, 07 February 2012, 04:02 GMT
Last edited by Allan McRae (Allan) - Tuesday, 07 February 2012, 04:25 GMT
Task Type Bug Report
Category makepkg
Status Closed
Assigned To Allan McRae (Allan)
Dave Reisner (falconindy)
Architecture All
Severity Medium
Priority Normal
Reported Version 4.0.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

With mercurial-2.1-1, `hg pull` returns 1 when no changes were found, that is, when the local copy is already up-to-date.

In that common case, makepkg traps an ERR for `hg pull` on line 1725 and exits with "An unknown error has occurred".

This can be "fixed" by making line 1725 read "hg pull || :" instead.
This task depends upon

Closed by  Allan McRae (Allan)
Tuesday, 07 February 2012, 04:25 GMT
Reason for closing:  Duplicate
Additional comments about closing:   FS#28248 
Comment by Dave Reisner (falconindy) - Tuesday, 07 February 2012, 04:13 GMT
This is the kind of thing I'd love to see fixed by removing errexit from makepkg outside of user functions... Not to mention that this only needs to be fixed in pacman because we treat hg differently from the other VCSs =(

Loading...