FS#16759 - better handling of encrypted root

Attached to Project: Release Engineering
Opened by Matthew (piezoelectric) - Wednesday, 21 October 2009, 00:14 GMT
Last edited by Dieter Plaetinck (Dieter_be) - Saturday, 06 March 2010, 09:50 GMT
Task Type Bug Report
Category AIF
Status Closed
Assigned To No-one
Architecture All
Severity Medium
Priority Normal
Reported Version 2009.08
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

The installer does not gracefully handle encrypted root setups.

First of all, the installer should mandate that a user specify a label for dm-crypt partitions. The input field could be populated with a default like "crypt_sda2" for /dev/sda2.

Second, the kernel command line options are not set correctly for Grub. Currently, they are created like "root=/dev/sda2" (and I guess the initrd figures out that it's a luks volume automatically). What should be written is "cryptdevice=/dev/sda2:crypt_root root=/dev/mapper/crypt_root". This setup will gracefully handle any label specified for the root volume.

Third, the generation of /etc/fstab should ensure that the label used for encrypted-root is used (right now I think /dev/mapper/root is set no matter what). So /dev/mapper/crypt_root in the above case.
This task depends upon

Closed by  Dieter Plaetinck (Dieter_be)
Saturday, 06 March 2010, 09:50 GMT
Reason for closing:  Fixed
Comment by Dieter Plaetinck (Dieter_be) - Wednesday, 11 November 2009, 12:19 GMT
patches welcome for 1 and 3.
issue 2 is something Thomas made a patch for. I will apply it soon
Comment by Dieter Plaetinck (Dieter_be) - Saturday, 06 March 2010, 09:50 GMT
issue 1 is fixed in git: http://github.com/Dieterbe/aif/commit/a3d214f7bd2f00d588209febfcbbcf3572119be9
issue 2 is fixed in git: http://github.com/Dieterbe/aif/commit/78c3557885de47020d34d9b7c1b3f6f1b7872633
issue 3 is fixed: we UUID's now. see  FS#17632 . if you really want labels, see  FS#14188 

Loading...