FS#13727 - [makepkg] VCS packages, makedepends and output

Attached to Project: Pacman
Opened by Allan McRae (Allan) - Monday, 09 March 2009, 23:48 GMT
Last edited by Allan McRae (Allan) - Friday, 10 August 2012, 04:56 GMT
Task Type Bug Report
Category makepkg
Status Closed
Assigned To No-one
Architecture All
Severity Very Low
Priority Normal
Reported Version 3.2.1
Due in Version 4.1.0
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Summary and Info:
devel_update() can get run before the VCS tool is installed as a makedep. Currently, the lack of VCS tool results in an immediate exit from devel_update(). This results in some interesting output:

==> Making package: notify-sharp-svn 3009-2 i686 (Mon Mar 9 08:23:02 UTC 2009)
...
==> Installing missing dependencies...
(subversion)
==> Entering fakeroot environment...
==> Determining latest svn revision...
-> Version found: 3032
(note the different version there and how --forcever does not seem to have been used/work)
...
==> Finished making: notify-sharp-svn 3009-2 i686 (Mon Mar 9 08:25:36 UTC 2009)

Maybe this can be improved somehow...
This task depends upon

Closed by  Allan McRae (Allan)
Friday, 10 August 2012, 04:56 GMT
Reason for closing:  Implemented
Additional comments about closing:  https://projects.archlinux.org/pacman.gi t/commit/?id=024bc44a
Comment by Dan McGee (toofishes) - Tuesday, 10 March 2009, 00:55 GMT
What are our current list of return codes from devel_update()?

Well now that I've looked, that function doesn't do at all what I expected. Maybe we need to be smart enough in devel_check() that we actually have a return code, and then check that in the main flow of makepkg?
Comment by Dan McGee (toofishes) - Tuesday, 10 March 2009, 00:56 GMT
And I know another thing we've said and is probably forgotten in some VCS PKGBUILD files- svn, git, cvs, etc. are supposed to be listed in makedepends. We should probably prefill those in the VCS PKGBUILD templates in the abs package.

Loading...