FS#9979 - gnumeric doesn't follow gnome packaging guidelines

Attached to Project: Arch Linux
Opened by Jan de Groot (JGC) - Thursday, 27 March 2008, 07:38 GMT
Last edited by Aaron Griffin (phrakture) - Friday, 09 May 2008, 17:23 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Aaron Griffin (phrakture)
Architecture All
Severity Medium
Priority Normal
Reported Version 2007.08-2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This task depends upon

Closed by  Aaron Griffin (phrakture)
Friday, 09 May 2008, 17:23 GMT
Reason for closing:  Fixed
Comment by Aaron Griffin (phrakture) - Thursday, 27 March 2008, 17:00 GMT
Just made a commit. Could you please check and see if I missed anything this time?
Comment by Jan de Groot (JGC) - Thursday, 27 March 2008, 18:08 GMT
The package looks almost perfect, some sidenotes still:

- gnome-doc-utils>=0.12.0 is missing from makedepends
- there's no "|| return 1" for configure, make install and the gconf-merge-schemas command
- if gnumeric doesn't require leftover empty directories, you could add !emptydirs to options
- desktop-file-utils is missing from depends.

The 2nd thing is something I found in all gnome packages, I fixed them during the 2.22 update round. Leaving the "|| return 1" option on make install can give you a half-installed package in case makeflags don't work out due to broken makefiles, which will go undetected if you don't watch the compiler output closely.
Comment by Aaron Griffin (phrakture) - Friday, 28 March 2008, 20:09 GMT
Commited and rebuilt. Please let me know what you think
Comment by Roman Kyrylych (Romashka) - Saturday, 05 April 2008, 10:29 GMT
the latest build (x86_64) is ok, just i686 version is needed.
So this can be closed now.

Loading...