FS#9552 - makepkg svn newpkgver function
Attached to Project:
Pacman
Opened by Zeqadious (Zeqadious) - Tuesday, 12 February 2008, 21:14 GMT
Last edited by Xavier (shining) - Tuesday, 12 February 2008, 22:30 GMT
Opened by Zeqadious (Zeqadious) - Tuesday, 12 February 2008, 21:14 GMT
Last edited by Xavier (shining) - Tuesday, 12 February 2008, 22:30 GMT
|
Details
Summary and Info:
When getting the svn log from a subversion repository, if the second line starts with an r the sed script used in the newpkgver function will fail (line 1004): sed: -e expression #1, char 28: unterminated `s' command Steps to Reproduce: I run makepkg on a PKGBUILD where the svn log --limit 1 output is: [zeqadious@Taylor XBMC]$ svn log https://xbmc.svn.sourceforge.net/svnroot/xbmc/branches/linuxport/XBMC --limit 1 ------------------------------------------------------------------------ r11633 | d4rkm4ster | 2008-02-12 14:08:45 -0500 (Tue, 12 Feb 2008) | 5 lines reverted: aspect ratio and alignment specification support for textures (r11598). Progress bar "curtain" effect have be achieved using the "<reveal>" tag as of r11617. When i use "svn log https://xbmc.svn.sourceforge.net/svnroot/xbmc/branches/linuxport/XBMC --limit 1 | sed -n 's/^r\([^ ]*\) .*$/\1/p'" I get: r11633 everted +++ Unfortunately I will not be able to reproduce this after they revision is bumped unless the next line starts with an r. This is a problem that will rarely show up I think, but it should still be reported :) |
This task depends upon
Closed by Xavier (shining)
Tuesday, 12 February 2008, 22:30 GMT
Reason for closing: Fixed
Additional comments about closing: will be fixed in 3.1.2 (commit f950c2630798e)
Tuesday, 12 February 2008, 22:30 GMT
Reason for closing: Fixed
Additional comments about closing: will be fixed in 3.1.2 (commit f950c2630798e)
http://projects.archlinux.org/git/?p=pacman.git;a=commitdiff;h=f950c2630798e03bbee314c4a3f2749d1293a2b3;hp=11692e0eef79e016859bb182917e56a12a14f734
Anyway, if all goes well, 3.1.2 will be released soon with the above fix.