FS#9196 - makechrootpkg: don't clear build dir at the end

Attached to Project: Pacman
Opened by Jaroslaw Swierczynski (swiergot) - Sunday, 13 January 2008, 16:25 GMT
Last edited by Dan McGee (toofishes) - Friday, 08 February 2008, 05:52 GMT
Task Type Feature Request
Category Scripts & Tools
Status Closed
Assigned To No-one
Architecture All
Severity Medium
Priority Normal
Reported Version git
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

IMHO it's not a good idea to clear the build directory just before exit, even if the build succeeded. Clearing it makes -R option of makepkg virtually useless. Attached is a patch that makes the behavior of makechrootpkg better.
   makechrootpkg-builddir.patch (0.8 KiB)
This task depends upon

Closed by  Dan McGee (toofishes)
Friday, 08 February 2008, 05:52 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in devtools 0.5, although we are going to need a 0.5.1 release soon for a small bug Simo found.
Comment by Jaroslaw Swierczynski (swiergot) - Sunday, 13 January 2008, 20:32 GMT
That patch obviously didn't have the right to work :/ Here is a new one.
Comment by Jaroslaw Swierczynski (swiergot) - Sunday, 13 January 2008, 20:33 GMT
Right here ;)
   makechrootpkg-builddir.patch (1 KiB)
Comment by Aaron Griffin (phrakture) - Tuesday, 15 January 2008, 22:52 GMT
Made the change locally, will be part of the next devtools push. Danke.
Comment by Jaroslaw Swierczynski (swiergot) - Wednesday, 16 January 2008, 06:42 GMT
Bitte.
Comment by Aaron Griffin (phrakture) - Wednesday, 16 January 2008, 18:55 GMT
http://code.phraktured.net/?p=devtools.git;a=commitdiff;h=2586acdde7c679526c0005b8289ecf15a5617460

Look ok?
Comment by Jaroslaw Swierczynski (swiergot) - Wednesday, 16 January 2008, 19:07 GMT
I'm affraid that this:

rm -rf "$uniondir/build/*"

will not work. It's like:

$ ls "/tmp/*"
ls: cannot access /tmp/*: No such file or directory

I intentionally wrote:

"$uniondir/build/"*

Note the asterisk _after_ the double quote.
Comment by Aaron Griffin (phrakture) - Wednesday, 16 January 2008, 19:13 GMT
Whoops: http://code.phraktured.net/?p=devtools.git;a=commitdiff;h=3dafd2077c0560b6ad31e4cfc7784b66622a5a10
Comment by Jaroslaw Swierczynski (swiergot) - Wednesday, 16 January 2008, 19:28 GMT
Seems fine.

Loading...