FS#8802 - grub depends on diffutils

Attached to Project: Arch Linux
Opened by Sepi Zsolt (subset) - Friday, 30 November 2007, 16:39 GMT
Last edited by Thomas Bächler (brain0) - Tuesday, 26 February 2008, 13:45 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Andreas Radke (AndyRTR)
Architecture All
Severity Low
Priority Normal
Reported Version 2007.08-2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 3
Private No

Details

grub-install need diffutils package (cmp need for grub-install)
This task depends upon

Closed by  Thomas Bächler (brain0)
Tuesday, 26 February 2008, 13:45 GMT
Reason for closing:  Fixed
Additional comments about closing:  fixed in -11
Comment by Jens Adam (byte) - Sunday, 02 December 2007, 14:13 GMT Comment by Dan McGee (toofishes) - Sunday, 02 December 2007, 15:35 GMT
Wow, one lousy usage of the cmp function (and it doesn't even look at the output!). I feel like we can factor this out, and it really doesn't need to be in core/base.

Does anyone good with shell scripting know a way to find out if two files are identical? test has the '-et' option, but I don't think that is quite what we are looking for here.
Comment by Andreas Radke (AndyRTR) - Sunday, 02 December 2007, 16:03 GMT
hm. not that good. and see also http://bugs.archlinux.org/task/8793. i still perfer to move diffutils to core.
Comment by Xavier (shining) - Sunday, 02 December 2007, 16:18 GMT
md5sum could be used, but I'm not sure that's any better.
Though it was apparently the solution adopted by another distrib:
http://lists.rpath.com/pipermail/distro-commits/2007-June/051738.html
Comment by Dan McGee (toofishes) - Sunday, 02 December 2007, 16:40 GMT
I'd prefer to patch it to use md5sum, but I really don't have anything invested in this so do whatever. Bug 8793 is not a simple shell script either, so we'd have to do some C patching which would get a bit uglier.

It's a bit off topic, but I'm just concerned that we may let "base" grow out of hand. As long as we aren't doing this with every small issue that comes up, we'll be OK. Given that at least two programs require diffutils, it may be wise to move it.
Comment by Sepi Zsolt (subset) - Sunday, 02 December 2007, 18:44 GMT
I mind :
When I can't use grub-install without any extra package ,then why it is the part of core/base ?
OR
Why doesn't core/base have diffutils package ?
:))
Comment by Jürgen Hötzel (juergen) - Sunday, 02 December 2007, 19:13 GMT
Me is against patching. Vanilla is the virtue of Arch.
Comment by Kenneth (ks1) - Sunday, 09 December 2007, 00:11 GMT
I think diffutils should be included. It is also needed to build kernel.

Loading...