FS#8556 - libdownload pachage is compiled with DEBUG

Attached to Project: Arch Linux
Opened by Nagy Gabor (combo) - Wednesday, 07 November 2007, 15:34 GMT
Last edited by Aaron Griffin (phrakture) - Wednesday, 28 November 2007, 07:21 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Aaron Griffin (phrakture)
Dan McGee (toofishes)
Architecture All
Severity Medium
Priority Normal
Reported Version 2007.08-2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

I said everything in the subject: the default DEBUG value in the Makefile of libarchive is true, and the current PKGBUILD doesn't sed this to false.
This is not a big problem, because makepkg autostrips the library, but IMHO you don't want to use -DDEBUG in Arch package.
This task depends upon

Closed by  Aaron Griffin (phrakture)
Wednesday, 28 November 2007, 07:21 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in 1.3-1
Comment by Dan McGee (toofishes) - Wednesday, 07 November 2007, 18:53 GMT
Hmm, can you explain a bit more? Greping the libarchive 2.4.0 Makefile I see no mention of DEBUG at all. Note that I ran ./configure with only the --prefix=/usr option. Is this something that has changed since 2.2.6?
Comment by Nagy Gabor (combo) - Thursday, 08 November 2007, 18:45 GMT
OMG!
I wanted to say libdownload (why I wrote the other pacman dep?! I dunno)
Sorry, sorry... I can be very stupid sometimes :-(
Comment by Dan McGee (toofishes) - Friday, 09 November 2007, 15:13 GMT
Aaron, this is your baby. Want to get a few things all out of the way at once in the actual source and not the PKGBUILD? Add a variable for enabling/disabling large file support (see the patch in ABS), make debug false by default, and add that libfetch compatibility header?

I hijacked this bug, oops.
Comment by Nagy Gabor (combo) - Sunday, 11 November 2007, 00:45 GMT
Dan, AFAIK you can override Makefile variables with the make command:
ngaba@durci:~/libdownload-1.2$ make DEBUG=false
...
built with: -O2 -pipe -I. -DINET6 -D_GNU_SOURCE -Wall -Wstrict-prototypes -Wsign-compare -Wchar-subscripts -Wpointer-arith -Wcast-align -Wsign-compare -UDEBUG

Loading...