Arch Linux

Please read this before reporting a bug:

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!

FS#8478 - patch for X wakeups

Attached to Project: Arch Linux
Opened by Ricardo Martins (meqif) - Thursday, 01 November 2007, 20:04 GMT
Last edited by Alexander Baldeck (kth5) - Friday, 09 November 2007, 14:35 GMT
Task Type Feature Request
Category Packages: Extra
Status Closed
Assigned To Alexander Baldeck (kth5)
Architecture All
Severity Low
Priority Normal
Reported Version 2007.08-2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Arjan van de Ven posted a patch[1] for fixing unnecessary wakeups caused by xorg-server. It applies cleanly to xorg-server-1.2.0-5. I think this would be appreciated by many laptop users.


This task depends upon

Closed by  Alexander Baldeck (kth5)
Friday, 09 November 2007, 14:35 GMT
Reason for closing:  Won't implement
Additional comments about closing:  This patch is not endorsed by upstream and has only very maginal advantages. In favor of not breaking things I won't apply this one.
Comment by Roman Kyrylych (Romashka) - Friday, 02 November 2007, 09:26 GMT
We already have xorg-server-1.3 in Extra and xorg-server-1.4 will be moved from Testing to Extra soon, plus such type of patches have a history of breaking things (like SSL was broken in Firefox after a similar patch from PowerTOP site (Intel's project too)).
So this kind of patches should be taken with care. Though I would *love* to see more such patches applied *mainstream*.
Comment by Ricardo Martins (meqif) - Friday, 02 November 2007, 10:13 GMT
You have a point. Arjan did submit the patch (against git) to the Xorg mailing list at 28 October [1], though he didn't receive a reply. I guess the patch applies cleanly to xorg-server 1.4 too.

Regarding brokenness, I haven't been using the patched xorg-server for long (only about a day), so it's too early to say for sure it doesn't break anything, but I haven't noticed odd behaviour until this moment.

Comment by Ricardo Martins (meqif) - Friday, 02 November 2007, 10:20 GMT
According to the xorg-commit ML, the patch was merged upstream [1]. Sorry for the noise. Judging by this, I guess it's safe to apply to older releases.