Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#8264 - Syslog-ng update broke logrotate

Attached to Project: Arch Linux
Opened by Glyn Adgie (glyn) - Tuesday, 09 October 2007, 07:16 GMT
Last edited by Roman Kyrylych (Romashka) - Wednesday, 30 January 2008, 21:09 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Eric Belanger (Snowman)
Aaron Griffin (phrakture)
Thomas Bächler (brain0)
Architecture All
Severity Medium
Priority Normal
Reported Version 2007.08-2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
syslog-ng update created /etc/logrotate.d/syslog-ng.pacnew. This caused logrotate to stop working, because it saw duplicate entries in /etc/logrotate.d/syslog-ng.

Additional info:
* package version(s)
syslog-ng-2.0.5-3,
logrotate-3.7.1-4

* config and/or log files etc.
/etc/logrotate.d/syslog-ng
/etc/logrotate.d/syslog-ng.pacnew

Steps to reproduce:
Copy any config file in /etc/logrotate.d to a new name. Run logrotate -vdf to see the results. As far as I can see, the only difference between the original /etc/logrotate.d/syslog-ng and the *.pacnew was that a space was removed ahead of an opening brace.

Fix:
Remove /etc/logrotate.d/syslog-ng, and rename /etc/logrotate.d/syslog-ng.pacnew, after any custom changes.
This task depends upon

Closed by  Roman Kyrylych (Romashka)
Wednesday, 30 January 2008, 21:09 GMT
Reason for closing:  Fixed
Comment by Roman Kyrylych (Romashka) - Tuesday, 09 October 2007, 09:48 GMT
Hm, I don't know how such breakage can be avoided on next change of default /etc/logrotate.d/syslog-ng
I think user should take a look at all .pacnew/.pacsave files immediately after -Syu so such issues are not a problem IMO.
Comment by Thomas Bächler (brain0) - Tuesday, 09 October 2007, 12:15 GMT
We could remove the file from backup=() to solve the issue long-term.

This issue only occurs if the user edited the file, so he should care about that.

So we either remove the possibility to change the file or live with a small bug that only occurs for those who change it. Another way would be a patch to logrotate that ignores .pacnew files, but this sounds unclean to me.

I am assigning this to phrakture as well, as it is a problem in our core system.
Comment by Aaron Griffin (phrakture) - Tuesday, 09 October 2007, 15:28 GMT
This isn't even a bug. It is up to the user to manage .pacnew and .pacsav files. We have always had this implicit contract - we provide the packages, you fix the config.

If someone posted a bug that said "I upgraded to foo-3.0 and it crashes with my current config file" it'd be the same "bug".
Comment by Jason Chu (jason) - Tuesday, 09 October 2007, 15:33 GMT
Tobias worked around this sort of thing with courier-mta... I don't know if we wanted to consider something like that.
Comment by Dan McGee (toofishes) - Tuesday, 08 January 2008, 06:11 GMT
# Ignore pacman saved files
tabooext + .pacorig .pacnew .pacsave

Fixed in CVS logrotate.conf. I think everyone overreacted here- it is a bug on our side since logrotate can clearly handle this problem.
Comment by Aaron Griffin (phrakture) - Tuesday, 08 January 2008, 06:48 GMT
The new conf file includes the tabooext directive, which disallows including of all out pacsave/pacorig/etc etc files in the inclue dir. Please test
Comment by Eric Belanger (Snowman) - Wednesday, 30 January 2008, 21:01 GMT
Is this fixed in the logrotate package in core? Can this bug be closed?
Comment by Roman Kyrylych (Romashka) - Wednesday, 30 January 2008, 21:08 GMT
Yes, this is fixed. Closing now.

Loading...