FS#80133 - [linux] 6.6 breaks Logitech G915 wireless keyboard

Attached to Project: Arch Linux
Opened by Marcelo Marzola Bossoni (mmbossoni) - Wednesday, 01 November 2023, 15:15 GMT
Last edited by Buggy McBugFace (bugbot) - Saturday, 25 November 2023, 20:13 GMT
Task Type Bug Report
Category Kernel
Status Closed
Assigned To No-one
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 3
Private No

Details

Description:
After upgrading linux-zen from 6.5 to 6.6 from testing, my keyboard (G915) stopped working.
It register only a few keys and not the proper ones, like it is all messed up

Additional info:


Steps to reproduce:
Use a fully up to date G915 keyboard/dongle

only difference I could see in journalctl is
```
nov 01 11:33:06 URSO kernel: logitech-hidpp-device 0003:046D:407C.0007: hidpp_root_get_protocol_version: received protocol error 0x08
```
   journal_good.txt (247.1 KiB)
   journal_bad.txt (226.1 KiB)
This task depends upon

Closed by  Buggy McBugFace (bugbot)
Saturday, 25 November 2023, 20:13 GMT
Reason for closing:  Moved
Additional comments about closing:  https://gitlab.archlinux.org/archlinux/p ackaging/packages/linux/issues/4
Comment by loqs (loqs) - Wednesday, 01 November 2023, 16:33 GMT
Possibly the same issue as [1] although the report lacks enough details to be certain and is not assigned to any component.
Please see [2] for kernel advice on kernel regressions. Let me know if you need any help with the bisection.

[1]: https://bugzilla.kernel.org/show_bug.cgi?id=218094
[2]: https://wiki.archlinux.org/title/Kernel#Debugging_regressions
Comment by Marcelo Marzola Bossoni (mmbossoni) - Thursday, 02 November 2023, 01:02 GMT
9d1bd9346241cd6963b58da7ffb7ed303285f684 is the first bad commit
commit 9d1bd9346241cd6963b58da7ffb7ed303285f684
Author: Mavroudis Chatzilazaridis <mavchatz@protonmail.com>
Date: Sun Jul 16 18:23:44 2023 +0000

HID: logitech-dj: Add support for a new lightspeed receiver iteration

The lightspeed receiver for the Pro X Superlight uses 13 byte mouse reports
without a report id. The workaround for such cases has been adjusted to
handle these larger packets.

The device now reports the status of its battery in wireless mode and
libratbag now recognizes the device and it can be configured with Piper.

https://github.com/libratbag/libratbag/pull/1122

Co-developed-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Mavroudis Chatzilazaridis <mavchatz@protonmail.com>
Reviewed-by: Bastien Nocera <hadess@hadess.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

drivers/hid/hid-ids.h | 1 +
drivers/hid/hid-logitech-dj.c | 11 ++++++++---
2 files changed, 9 insertions(+), 3 deletions(-)
Comment by loqs (loqs) - Thursday, 02 November 2023, 08:34 GMT
Thank you for performing the bisection. I would suggest you try and add the following to the CC list of the upstream bug report Mavroudis Chatzilazaridis <mavchatz@protonmail.com> Filipe Laíns <lains@riseup.net> Bastien Nocera <hadess@hadess.net> Jiri Kosina <jkosina@suse.cz>
Edit:
The report has now been forwarded to the Linux Regressions mailing list [1] and the four developers I mentioned are on the CC list.

[1]: https://lore.kernel.org/regressions/6929ebbf-f2e0-4cd4-addc-1e33ecf3277f%40gmail.com/
Comment by loqs (loqs) - Wednesday, 15 November 2023, 14:52 GMT
If you revert the support for 13 byte reports but keep the addition of 046d:c547 as suggested in [1] is the issue still present?

[1]: https://bugzilla.kernel.org/show_bug.cgi?id=218094#c27
   test.patch (0.7 KiB)
Comment by Marcelo Marzola Bossoni (mmbossoni) - Wednesday, 15 November 2023, 16:46 GMT
No, it doesn't work.
The only thing that work is removing these lines

[code]
{ /* Logitech lightspeed receiver (0xc547) */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
USB_DEVICE_ID_LOGITECH_NANO_RECEIVER_LIGHTSPEED_1_2),
.driver_data = recvr_type_gaming_hidpp},
[/code]

Which makes more sense to me since that report size code is protected by an "djrcv_dev->unnumbered_application == HID_GD_MOUSE", meaning it will only run for mouse/pointers, not keyboards.
Comment by loqs (loqs) - Tuesday, 21 November 2023, 14:01 GMT
Upstream intends to revert 9d1bd9346241cd6963b58da7ffb7ed303285f684 as its author is unresponsive [1][2].
Edit:
Author of 9d1bd9346241cd6963b58da7ffb7ed303285f684 agrees with the revert [5].

Note the Logitech G510s keyboard - sysfs: cannot create duplicate filename [3] is a separate issue which will likely result in the revert of c7d80059b086c4986cd994a1973ec7a5d75f8eea.

Consider picking up 5b4ffb176d7979ac66b349addf3f7de433335e00 and possibly locally reverting c7d80059b086c4986cd994a1973ec7a5d75f8eea?
Edit:
Proposed partial revert of c7d80059b086c4986cd994a1973ec7a5d75f8eea [6].
Edit2:
Revert "HID: logitech-dj: Add support for a new lightspeed receiver iteration" queued for 6.3.3 [7].

[1]: https://lore.kernel.org/regressions/nycvar.YFH.7.76.2311211435050.29220%40cbobk.fhfr.pm/
[2]: https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?id=5b4ffb176d7979ac66b349addf3f7de433335e00
[3]: https://bugzilla.kernel.org/show_bug.cgi?id=218155
[4]: https://lore.kernel.org/regressions/b5646db3-acff-45aa-baef-df3f660486fb%40gmail.com/
[5]: https://lore.kernel.org/regressions/4071999d-77ca-4a75-a9e0-d8ccac0dada1%40protonmail.com/
[6]: https://lore.kernel.org/linux-leds/20231121162359.9332-1-tiwai%40suse.de/
[7]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5b4ffb176d7979ac66b349addf3f7de433335e00

Loading...