FS#79962 - [libguestfs] `prepare` accesses source files outside of `$srcdir`.
Attached to Project:
Arch Linux
Opened by Oid Maps (dreieck) - Saturday, 14 October 2023, 17:38 GMT
Last edited by Toolybird (Toolybird) - Saturday, 14 October 2023, 17:43 GMT
Opened by Oid Maps (dreieck) - Saturday, 14 October 2023, 17:38 GMT
Last edited by Toolybird (Toolybird) - Saturday, 14 October 2023, 17:43 GMT
|
Details
Description:
The `PKGBUILD` of the package extra/libguestfs wants to read in `prepare()` source files outside of `$srcdir`: ``` prepare() { patch -Np1 -d $pkgname-$pkgver -i ../$pkgname-1.48.1-disable_php_tests.patch patch -Np1 -d $pkgname-$pkgver -i ../$pkgname-1.48.6-ocaml5.patch [...] ``` Note that at the beginning of `prepare()`, we start at `$srcdir`, and then a file in ../ is accessed. This is against the rules of writing packages, and will fail if `$SRCDEST` is set (which is a supported variable by `makepkg`). Please use `"${srcdir}/<patchfile>"`. Additional info: * package version(s): 1.50.1-1 Regards! |
This task depends upon
Closed by Toolybird (Toolybird)
Saturday, 14 October 2023, 17:43 GMT
Reason for closing: Not a bug
Additional comments about closing: See comments
Saturday, 14 October 2023, 17:43 GMT
Reason for closing: Not a bug
Additional comments about closing: See comments
Comment by Toolybird (Toolybird) -
Saturday, 14 October 2023, 17:43 GMT
man patch. Note the -d option.