FS#79597 - [httpie] FTBFS (checksum mismatch)

Attached to Project: Arch Linux
Opened by Levi Zim (kxxt) - Thursday, 07 September 2023, 04:57 GMT
Last edited by Buggy McBugFace (bugbot) - Saturday, 25 November 2023, 20:19 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Jelle van der Waa (jelly)
Daurnimator (daurnimator)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

==> Validating source files with sha256sums...
httpie-3.2.1.tar.gz ... FAILED
httpie-3.2.1-py311.patch ... Passed

By the way, upstream changed their repo url to https://github.com/httpie/cli.

Additional info:
* package version(s) 3.2.1-4
* patch attached.
   fix.patch (0.9 KiB)
This task depends upon

Closed by  Buggy McBugFace (bugbot)
Saturday, 25 November 2023, 20:19 GMT
Reason for closing:  Moved
Additional comments about closing:  https://gitlab.archlinux.org/archlinux/p ackaging/packages/httpie/issues/1
Comment by Levi Zim (kxxt) - Thursday, 07 September 2023, 05:05 GMT
And check() is failing:

FAILED tests/test_compress.py::test_compress_form[http] - AssertionError: ass...
FAILED tests/test_compress.py::test_compress_form[https] - AssertionError: as...
FAILED tests/test_binary.py::TestBinaryResponseData::test_binary_suppresses_when_terminal
FAILED tests/test_binary.py::TestBinaryResponseData::test_binary_suppresses_when_not_terminal_but_pretty
FAILED tests/test_binary.py::TestBinaryResponseData::test_binary_included_and_correct_when_suitable
FAILED tests/test_cookie_on_redirects.py::test_saved_session_cookie_pool - te...
= 6 failed, 974 passed, 4 skipped, 38 deselected, 2 xfailed, 2 xpassed, 201 warnings in 63.05s (0:01:03) =
Comment by Levi Zim (kxxt) - Thursday, 07 September 2023, 08:27 GMT
I did some bisect and found that `Werkzeug>=2.3.0` caused the tests to fail.

I attached a fix that:
1. Update httpie version to 3.2.2
2. Use new upstream repo url
3. Fix the tests by creating a venv and install Werkzeug<2.3.0 in it. Tests are run in the venv.

Comment by Levi Zim (kxxt) - Thursday, 07 September 2023, 08:27 GMT
See the attached fix for more details
   fix.patch (2.2 KiB)
Comment by loqs (loqs) - Thursday, 07 September 2023, 09:05 GMT
werkzeug<2.1.0 was added in [1] because of an issue in httpbin. Unfortunately the PR did not include the test failures and it does not appear the suggested tracking issue was opened either. werkzeug 2.1 support was added to the psf fork of httpbin Arch uses in [2]. Could you open a new upstream issue? As your patch installs werkzeug 2.2.3 and passes all tests so httpie appears to be at least compatible with the 2.2 series of werkzeug.

[1] https://github.com/httpie/cli/pull/1345
[2] https://github.com/psf/httpbin/commit/496d0b96c3a8c843803e18ac6d8a379b94b4f215
Comment by loqs (loqs) - Thursday, 07 September 2023, 09:59 GMT
What if you skip the failing tests instead of installing wekzeug 2.2.3 in the venv? fix.diff applies on top of fix.patch and also stops skipping tests that now pass.
   fix.diff (1.1 KiB)
Comment by loqs (loqs) - Sunday, 10 September 2023, 19:06 GMT
https://github.com/httpie/cli/issues/1530

Loading...