FS#79527 - [libvips] 8.14.2-2 is built in debug mode

Attached to Project: Arch Linux
Opened by John Cupitt (jcupitt) - Thursday, 31 August 2023, 14:09 GMT
Last edited by Justin Kromlinger (hashworks) - Tuesday, 14 November 2023, 17:42 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Justin Kromlinger (hashworks)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 2
Private No

Details

libvips 8.14 defaults to a debug build. Add `--buildtype release` to the meson command to get a release (optimised) build.

We've changed the default to release for 8.15, but for 8.14 you need to enable a release build explicitly.

Perhaps:

```
build() {
meson build vips-$pkgver \
--buildtype release \
--prefix=/usr \
-Dgtk_doc=true
meson compile -C build
}
```
This task depends upon

Closed by  Justin Kromlinger (hashworks)
Tuesday, 14 November 2023, 17:42 GMT
Reason for closing:  Fixed
Additional comments about closing:  8.15.0-1
Comment by Toolybird (Toolybird) - Thursday, 31 August 2023, 21:39 GMT
Thanks for the headsup! Unfortunately this pkg is currently orphaned i.e. no Arch maintainer. Luckily, the Arch build system overrides the built-in CFLAGS and debug option with our preferred flags so this issue doesn't really matter too much. If anything, we would change it to `--buildtype=plain' as per the Arch meson package guidelines [1]. libvips is currently depended upon by "imaginary" and "signal-desktop" so the maintainers of those pkgs have been notified as a hint to adopt this pkg.

[1] https://wiki.archlinux.org/title/Meson_package_guidelines
Comment by John Cupitt (jcupitt) - Thursday, 31 August 2023, 22:50 GMT
  • Field changed: Percent Complete (100% → 0%)
I think this should probably be changed -- at the moment, if someone installs libvips using the arch package manager, they'll get a debug build.

This includes things like leak checking, extra tests for casts, sanity checking, stuff like that. It's at least 2x slower than a release build.

It also prints extra annoying stuff, like a memory use summary on exit.

I learned about this on this issue, fwiw:

https://github.com/libvips/pyvips/issues/419
Comment by Just Kidding (justkdng) - Saturday, 14 October 2023, 17:01 GMT
Thanks for reporting, my project also uses libvips and was getting a lot of issues regarding the debug output. Had to adopt the libvips-git aur package in order to fix it. It's a shame that current libvips has no maintainer.

Also, seems libvips does runtime checks for the buildtype, independent of arch's flags or the debug symbol stripping done later, so I'm not sure if setting it to plain would help.
Comment by Marcell Meszaros (MarsSeed) - Tuesday, 14 November 2023, 00:48 GMT
Recently, the repo package libvips got adopted by maintainer Justin Kromlinger (@hashworks).
Comment by John Cupitt (jcupitt) - Tuesday, 14 November 2023, 09:56 GMT
Thank you for adopting this package, @hashworks!

libvips 8.15 was released a few days ago and has changed the default build to "release", so updating the package should be enough to resolve this.

https://github.com/libvips/libvips/releases/tag/v8.15.0

There have been some changes in the dependencies: it's now libarchive instead of libgsf, and Highway instead of Orc.

Loading...