FS#7950 - patch support in makepkg

Attached to Project: Pacman
Opened by Curtis Smith (csc) - Monday, 03 September 2007, 19:19 GMT
Last edited by Aaron Griffin (phrakture) - Thursday, 04 October 2007, 02:06 GMT
Task Type Feature Request
Category makepkg
Status Closed
Assigned To Aaron Griffin (phrakture)
Dan McGee (toofishes)
Architecture All
Severity Low
Priority Normal
Reported Version 3.0.5
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Patching option/support in Makepkg/abs to apply patches to source code.
This task depends upon

Closed by  Aaron Griffin (phrakture)
Thursday, 04 October 2007, 02:06 GMT
Reason for closing:  Won't implement
Comment by Pierre Schmitz (Pierre) - Monday, 03 September 2007, 20:17 GMT
You can just use patch within build().
Comment by Curtis Smith (csc) - Tuesday, 04 September 2007, 03:17 GMT
But why cant makepkg patch the source code after it extracts the archives? wouldnt that be easier and more efficient?
Comment by Allan McRae (Allan) - Tuesday, 04 September 2007, 11:06 GMT
It would have to automatically detect the -p<0/1/2...> flag to use or else that would have to be supplied in the package build which kind of ruins the the point of the request.
Comment by Roman Kyrylych (Romashka) - Wednesday, 05 September 2007, 17:44 GMT
AFAIR this was discussed some time ago on pacman-dev ML and IIRC it was decided that this is not worth it.
Comment by Dan McGee (toofishes) - Thursday, 06 September 2007, 01:45 GMT
-1 here unless someone gives a compelling reason and/or proof of concept patch that doesn't overcomplicate makepkg.

Reasons for vote against:
1. If someone wants to recompile with/without a patch, it is much easier to just stick a '#' at the beginning of a line.
2. The -p comment voiced above.
3. makepkg options that don't touch the src/ dir could get tricky (-e).
4. Not sure how it is more efficient to have makepkg do it, it would just be doing the same thing build does but in a more convoluted fashion.
Comment by Aaron Griffin (phrakture) - Thursday, 04 October 2007, 02:06 GMT
I'm going to -1 this here as well.

Like Dan said, if you can find an elegant way to implement this, please request this bug be reopened.

Loading...