FS#79382 - [dkms] Various suggestions/rework from upstream

Attached to Project: Arch Linux
Opened by Emil (xexaxo) - Tuesday, 15 August 2023, 11:07 GMT
Last edited by Buggy McBugFace (bugbot) - Saturday, 25 November 2023, 20:25 GMT
Task Type Feature Request
Category Packages: Extra
Status Closed
Assigned To Sébastien Luttringer (seblu)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

As mentioned in my upstream MR [1], there are some bits that we can do today:
- the 4 year old PKGBUILD.26 can be removed
- the moddir patching aka s,/lib/modules,/usr/lib/modules,g should be dropped - we don't patch kmod either
- BASHDIR can be dropped, it's the default

The second to last one - SBIN, KCONF and LIBDIR are relative to DESTDIR so they should be updated - would need to follow-up as we get a new release.

With my upstream maintainer hat on, I would love to see hook.sh to become a simple wrapper, although I did not have the time to RE what it's aiming to do :-)
My gut suggests that most of it can be replaced by dkms autoinstall.

Additional info:
* package version(s)
3.0.11-1

* link to upstream bug report, if any
[1] https://github.com/dell/dkms/pull/339

Steps to reproduce:
- drop the PKGBUILD.26, BASHDIR and moddir mangling
- rebuild the package
- observe it still works as expected
This task depends upon

Closed by  Buggy McBugFace (bugbot)
Saturday, 25 November 2023, 20:25 GMT
Reason for closing:  Moved
Additional comments about closing:  https://gitlab.archlinux.org/archlinux/p ackaging/packages/dkms/issues/2
Comment by Emil (xexaxo) - Thursday, 21 September 2023, 18:10 GMT
Upstream MR has landed. Will try and roll our a release in the upcoming days.
Comment by Emil (xexaxo) - Sunday, 24 September 2023, 12:57 GMT
Just made a v3.0.12 release. Let me know if I can help move things on Arch side.

Loading...