FS#79336 - [electron25] FTBFS (missing make dependency)

Attached to Project: Arch Linux
Opened by Levi Zim (kxxt) - Wednesday, 09 August 2023, 05:40 GMT
Last edited by Toolybird (Toolybird) - Thursday, 10 August 2023, 21:05 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Caleb Maclennan (alerque)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
missing python-requests make dependency.

==> Starting prepare()...
Linking chromium from sources...
WARNING: Your metrics.cfg file was invalid or nonexistent. A new one will be created.
Traceback (most recent call last):
File "/build/electron25/src/depot_tools/gclient.py", line 118, in <module>
import git_cl
File "/build/electron25/src/depot_tools/git_cl.py", line 48, in <module>
import presubmit_support
File "/build/electron25/src/depot_tools/presubmit_support.py", line 50, in <module>
import rdb_wrapper
File "/build/electron25/src/depot_tools/rdb_wrapper.py", line 9, in <module>
import requests
ModuleNotFoundError: No module named 'requests'
==> ERROR: A failure occurred in prepare().
Aborting...

Additional info:
* package version(s) 25.3.2-1
* patch attached
   fix.patch (0.7 KiB)
This task depends upon

Closed by  Toolybird (Toolybird)
Thursday, 10 August 2023, 21:05 GMT
Reason for closing:  Fixed
Additional comments about closing:  electron25 25.3.2-2
Comment by loqs (loqs) - Wednesday, 09 August 2023, 15:56 GMT
Could https://chromium.googlesource.com/chromium/tools/depot_tools.git be pinned in all the electron PKGBUILDs to stop this from happening and make the builds more reproducible?
Comment by Levi Zim (kxxt) - Thursday, 10 August 2023, 00:23 GMT
@loqs Yes, it could be pinned. We can get the exact commit from the DEPS file[1]. I have written a simple script[2] to parse it and pin various build tools to their specific commit[3].

1: https://github.com/chromium/chromium/blob/90fd82af5188b501daaa8f9dc54bf3feb4fba03f/DEPS#L1278-L1279
2. https://github.com/felixonmars/archriscv-packages/blob/master/electron24/electron24-deps-parser.py
3. https://github.com/felixonmars/archriscv-packages/blob/master/electron24/riscv64.patch

Loading...