FS#79330 - [mygui] openmw fails to build with 3.4.3

Attached to Project: Arch Linux
Opened by Lone_Wolf (Lone_Wolf) - Tuesday, 08 August 2023, 14:40 GMT
Last edited by Buggy McBugFace (bugbot) - Saturday, 25 November 2023, 20:27 GMT
Task Type General Gripe
Category Packages: Extra
Status Closed
Assigned To Sven-Hendrik Haase (Svenstaro)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Mygui 3.4.3 has changes that break openmw build.

Please delay updating until openmw devs have found a fix & backported it to latest release (currently 0.48) .

See https://gitlab.com/OpenMW/openmw/-/issues/7528
This task depends upon

Closed by  Buggy McBugFace (bugbot)
Saturday, 25 November 2023, 20:27 GMT
Reason for closing:  Moved
Additional comments about closing:  https://gitlab.archlinux.org/archlinux/p ackaging/packages/mygui/issues/1
Comment by Toolybird (Toolybird) - Tuesday, 08 August 2023, 21:26 GMT
Please let us know when resolved ASAP
Comment by Lone_Wolf (Lone_Wolf) - Thursday, 26 October 2023, 19:27 GMT
Fixes for mygui 3.4.3 as well as an increase of the required minimum version of mygui to 3.4.3 have ben merged to master , see https://gitlab.com/OpenMW/openmw/-/commit/6a87ba8f333481636359c5cd250ed14f0b3108e7
Maybe an mygui 3.4.3 package can be provided in testing repo or pkgbuild.com to verify whether openmw master & 0.48 will work with it ?
Comment by loqs (loqs) - Thursday, 26 October 2023, 23:06 GMT
openmw-git 0.48.0.r3465.g8380da2e1d-1 from AUR fails to build with mygui 3.4.3. The upstream merge commit does not apply cleanly openmw 0.48.0.
@Lone_Wolf do you have a patch that does apply?
Edit:
Attached diff for mygui PKGBUILD update [1] and the build failure for openmw-git [2].

[1]: PKGBUILD.diff.mygui
[2]: openmw-git-0.48.0.r3465.g8380da2e1d-1-x86_64-build.log.xz
   PKGBUILD.diff.mygui (0 KiB)
   openmw-git-0.48.0.r3465.g8380... (13.3 KiB)
Comment by loqs (loqs) - Friday, 27 October 2023, 00:08 GMT
Correct PKGBUILD.diff.mygui instead of any empty file.
   PKGBUILD.diff.mygui (0.8 KiB)
Comment by Lone_Wolf (Lone_Wolf) - Friday, 27 October 2023, 00:43 GMT
By adding -D OPENMW_USE_SYSTEM_MYGUI=OFF to the cmake invocation the build for master 8380da2e1d does succeed.

It seems we may need to change the build options for mygui .

https://gitlab.com/OpenMW/openmw/-/blob/master/extern/CMakeLists.txt?ref_type=heads#L64 shows what settings openmw uses to build it's own version of mygui.

My money is on the MYGUI_DONT_USE_OBSOLETE option as that has been the cause of lengthy discussions between openmw & mygui devs.
To tired to continue, going to sleep now.

Comment by loqs (loqs) - Friday, 27 October 2023, 01:02 GMT
> My money is on the MYGUI_DONT_USE_OBSOLETE option as that has been the cause of lengthy discussions between openmw & mygui devs.
That fixed the openmw-git build.
Comment by Lone_Wolf (Lone_Wolf) - Friday, 27 October 2023, 09:39 GMT
Confirmed and a quick playtest showed no issues.

The hack to get demos installed to /opt doesn't work anymore. Also -DMYGUI_INSTALL_SAMPLES=TRUE and -DMYGUI_INSTALL_MEDIA=TRUE are no longer used by mygui.

I've attached a patch file against current 3.4.2 PKGBUILD.

Will start looking into applying the upstream patch to 0.48 branch.
   adjustments-for-3.4.3.patch (1.9 KiB)
Comment by Lone_Wolf (Lone_Wolf) - Friday, 27 October 2023, 21:03 GMT
I've looked at the 11 individual commits that make up the patch mnetioned in #2 . They are shown in openmw MR 3319 , https://gitlab.com/OpenMW/openmw/-/merge_requests/3319 .

Unfortunately the number of commits after 0.48 was branched off over a year ago makes it impractable to backport the mygui 3.4.3 patch by cherrypicking commits .

There's no timeframe for when 0.49 will be released, but judging by past releases I'd be surprised if it happens before Q4 2024 .

As far as I can tell openmw is the only user of mygui in archlinux repos, while in aur it's mainly openmw-git .

Some possible solutions / workarounds :

Keep mygui 2.4.2 in repos and do nothing with 2.4.3 until 0.49 is released

switch mygui to a non-sytem external dep in the 0.48 PKGBUILD and drop mygui to aur .

Update the repo openmw package to build from a pinned git commit (at or after the mygui 3.4.3 patch) instead of the 0.48 tarball .
This would allow updating mygui in repos to 3.4.3 .


@Svenstaro: the decision lies with you and other archlinux devs.


Comment by Lone_Wolf (Lone_Wolf) - Wednesday, 01 November 2023, 21:13 GMT
Several days have passed and there was no response at all to my last 2 comments.
I am already using a local mygui-openmw 3.4.3 package with openmw trunk and intend to upload that to AUR this weekend so it can be used for openmw-git .


FYI :

An issue that requires a (small) change in openmw sourcecode related to mygui 3.4.3 has been found and is being solved in [2] .


[1] https://gitlab.com/OpenMW/openmw/-/merge_requests/3319#note_1625554232
[2] https://gitlab.com/OpenMW/openmw/-/merge_requests/3541

Loading...