Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#79216 - [shadow] Make shadow.service not to fail on non-existing paths

Attached to Project: Arch Linux
Opened by Hanabishi (Hanabishi) - Thursday, 27 July 2023, 07:11 GMT
Last edited by David Runge (dvzrv) - Monday, 18 September 2023, 15:30 GMT
Task Type General Gripe
Category Packages: Core
Status Closed
Assigned To David Runge (dvzrv)
Giancarlo Razzolini (grazzolini)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

Currently shadow.service fails critically on non-existing paths (shell paths, home paths, ...) dropping systemd into degraded state.
Which is no good overall, maybe such errors should be only treated as warnings and not fail the service.

Related issues:
https://bugs.archlinux.org/task/79213
https://bugs.archlinux.org/task/76451
https://bugs.archlinux.org/task/49453
https://bugs.archlinux.org/task/46204
https://bugs.archlinux.org/task/44748

Additional info:
* package version(s):
shadow 4.13-2
This task depends upon

Closed by  David Runge (dvzrv)
Monday, 18 September 2023, 15:30 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed with 4.14.0-2
Comment by Toolybird (Toolybird) - Thursday, 27 July 2023, 07:37 GMT
This is effectively requesting a revert of  FS#54286 
Comment by Hanabishi (Hanabishi) - Thursday, 27 July 2023, 08:01 GMT
Not really. It is ok to fail in case of real problems (e.g. the file is actually corrupted).
If it can not be solved on the package level, maybe it should be addressed upstream.
Comment by Hanabishi (Hanabishi) - Thursday, 27 July 2023, 08:16 GMT
I analyzed the source of pwck and seems like we actually fine to simply go with '-q' flag. There are no really useful warnings as for background maintainance task.
(Yes, warnings are made to cause erroneous exit code for some reason. But in quiet mode they are skipped completely and do not affect the exit code.)
Comment by David Runge (dvzrv) - Saturday, 02 September 2023, 17:02 GMT
@Hanabishi thanks for looking into this.

I'll push a rebuild to testing
Comment by David Runge (dvzrv) - Saturday, 02 September 2023, 17:10 GMT
Hm, looking again at all the linked issues I realized that -q is likely *not* what we want.
We want to fail and have a privileged user clean up the issues.

Loading...