FS#79203 - [xreader] FTBFS with meson 1.2

Attached to Project: Arch Linux
Opened by Link (Extension-Prompt-440) - Tuesday, 25 July 2023, 22:51 GMT
Last edited by Antonio Rojas (arojas) - Saturday, 05 August 2023, 07:57 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Bruno Pagani (ArchangeGabriel)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

[ Description ]
Downloading the latest PKGBUILD for this package from the official Arch Linux GitLab page & running "makepkg -si" in the directory it is downloaded to consistently leads to compilation errors & the package not being built.

[ Additional info ]
Same result whether its on my main system with custom config or a freshly installed system with 100 percent default configuration for everything.
I did not edit the PKGBUILD. Errors occur with the provided PKGBUILD.
I even tried cloning the official GitHub repo for xreader & manually running the commands contained within the PKGBUILD on the cloned repo, same exact errors.
The errors start after the "[355/361] Linking target libview/libxreaderview.so.3.0.0" line
I have base-devel installed & installed packages are fully up to date.

[ Steps to reproduce ]
git clone https://gitlab.archlinux.org/archlinux/packaging/packages/xreader
cd xreader
makepkg -si
(proceeds to fail to build no matter what I do, custom or default config, new or old Arch Linux installation)

[ Log Output ]
[354/361] Linking target backend/pdf/libpdfdocument.so
[355/361] Linking target libview/libxreaderview.so.3.0.0
In file included from /usr/include/bits/libc-header-start.h:33,
from /usr/include/limits.h:26,
from /usr/lib/gcc/x86_64-pc-linux-gnu/13.1.1/include/limits.h:205,
from /usr/lib/gcc/x86_64-pc-linux-gnu/13.1.1/include/syslimits.h:7,
from /usr/lib/gcc/x86_64-pc-linux-gnu/13.1.1/include/limits.h:34,
from /usr/lib/glib-2.0/include/glibconfig.h:11,
from /usr/include/glib-2.0/glib/gtypes.h:34,
from /usr/include/glib-2.0/glib/galloca.h:34,
from /usr/include/glib-2.0/glib.h:32,
from /usr/include/glib-2.0/gobject/gbinding.h:30,
from /usr/include/glib-2.0/glib-object.h:24,
from /tmp/makepkg/xreader/src/xreader-3.8.2/libdocument/ev-annotation.h:29,
from /tmp/makepkg/xreader/src/build/g-ir-cpp-d_kvodk_.c:4:
/usr/include/features.h:413:4: warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp]
413 | # warning _FORTIFY_SOURCE requires compiling with optimization (-O)
| ^~~~~~~
../xreader-3.8.2/libdocument/ev-annotation.c:706: Warning: XreaderDocument: multiple comment blocks documenting 'ev_annotation_set_area:' identifier (already seen at ev-annotation.c:687).
../xreader-3.8.2/libdocument/ev-file-helpers.c:200: Error: XreaderDocument: identifier not found on the first line:
* This function is copied from
^
../xreader-3.8.2/libdocument/ev-document-misc.c:31: Error: XreaderDocument: identifier not found on the first line:
* Returns a new GdkPixbuf that is suitable for placing in the thumbnail view.
^
../xreader-3.8.2/libdocument/ev-document-info.h:70: Warning: XreaderDocument: symbol='PERMISSIONS_FULL': Unknown namespace for symbol 'PERMISSIONS_FULL'
../xreader-3.8.2/libdocument/ev-document-misc.h:37: Warning: XreaderDocument: symbol='DEFAULT_DPI': Unknown namespace for symbol 'DEFAULT_DPI'
../xreader-3.8.2/libdocument/ev-document.c:423: Warning: XreaderDocument: ev_document_synctex_backward_search: unknown parameter 'page' in documentation comment, should be 'page_index'
../xreader-3.8.2/libdocument/ev-backends-manager.h:42: Warning: XreaderDocument: ev_backends_manager_get_document: return value: Missing (transfer) annotation
../xreader-3.8.2/libdocument/ev-backends-manager.h:48: Warning: XreaderDocument: ev_backends_manager_get_document_type_info: return value: Invalid non-constant return of bare structure or union; register as boxed type or (skip)
../xreader-3.8.2/libdocument/ev-backends-manager.h:50: Warning: XreaderDocument: ev_backends_manager_get_all_types_info: return value: Missing (element-type) annotation
../xreader-3.8.2/libdocument/ev-mapping-list.h:37: Warning: XreaderDocument: ev_mapping_list_ref: return value: Invalid non-constant return of bare structure or union; register as boxed type or (skip)
../xreader-3.8.2/libdocument/ev-mapping-list.h:41: Warning: XreaderDocument: ev_mapping_list_get_list: return value: Missing (element-type) annotation
../xreader-3.8.2/libdocument/ev-mapping-list.h:42: Warning: XreaderDocument: ev_mapping_list_find: return value: Invalid non-constant return of bare structure or union; register as boxed type or (skip)
../xreader-3.8.2/libdocument/ev-mapping-list.h:44: Warning: XreaderDocument: ev_mapping_list_find_custom: argument func: Missing (scope) annotation for callback without GDestroyNotify (valid: call, async, forever)
../xreader-3.8.2/libdocument/ev-mapping-list.h:44: Warning: XreaderDocument: ev_mapping_list_find_custom: return value: Invalid non-constant return of bare structure or union; register as boxed type or (skip)
../xreader-3.8.2/libdocument/ev-mapping-list.h:52: Warning: XreaderDocument: ev_mapping_list_nth: return value: Invalid non-constant return of bare structure or union; register as boxed type or (skip)
../xreader-3.8.2/libdocument/ev-mapping-list.h:34: Warning: XreaderDocument: ev_mapping_list_new: argument list: Missing (element-type) annotation
../xreader-3.8.2/libdocument/ev-mapping-list.h:34: Warning: XreaderDocument: ev_mapping_list_new: return value: Invalid non-constant return of bare structure or union; register as boxed type or (skip)
../xreader-3.8.2/libdocument/ev-mapping-list.h:34: Warning: XreaderDocument: ev_mapping_list_new: argument list: Missing (element-type) annotation
../xreader-3.8.2/libdocument/ev-mapping-list.h:34: Warning: XreaderDocument: ev_mapping_list_new: return value: Invalid non-constant return of bare structure or union; register as boxed type or (skip)
../xreader-3.8.2/libdocument/ev-file-helpers.c:175: Warning: XreaderDocument: ev_mkstemp_file: return value: Missing (transfer) annotation
../xreader-3.8.2/libdocument/ev-document.h:149: Warning: XreaderDocument: ev_document_get_page: return value: Missing (transfer) annotation
../xreader-3.8.2/libdocument/ev-document.c:479: Warning: XreaderDocument: ev_document_synctex_forward_search: return value: Invalid non-constant return of bare structure or union; register as boxed type or (skip)
../xreader-3.8.2/libdocument/ev-document.h:125: Warning: XreaderDocument: ev_document_get_doc_mutex: return value: Invalid non-constant return of bare structure or union; register as boxed type or (skip)
../xreader-3.8.2/libdocument/ev-document.h:131: Warning: XreaderDocument: ev_document_get_fc_mutex: return value: Invalid non-constant return of bare structure or union; register as boxed type or (skip)
../xreader-3.8.2/libdocument/ev-document-misc.h:42: Warning: XreaderDocument: ev_document_misc_get_thumbnail_frame: return value: Missing (transfer) annotation
../xreader-3.8.2/libdocument/ev-document-misc.h:46: Warning: XreaderDocument: ev_document_misc_get_loading_thumbnail: return value: Missing (transfer) annotation
../xreader-3.8.2/libdocument/ev-document-misc.h:50: Warning: XreaderDocument: ev_document_misc_render_loading_thumbnail: return value: Missing (transfer) annotation
../xreader-3.8.2/libdocument/ev-document-misc.h:54: Warning: XreaderDocument: ev_document_misc_render_thumbnail_with_frame: return value: Missing (transfer) annotation
../xreader-3.8.2/libdocument/ev-document-misc.h:69: Warning: XreaderDocument: ev_document_misc_pixbuf_from_surface: return value: Missing (transfer) annotation
../xreader-3.8.2/libdocument/ev-document-annotations.h:91: Warning: XreaderDocument: ev_document_annotations_get_annotations: return value: Invalid non-constant return of bare structure or union; register as boxed type or (skip)
../xreader-3.8.2/libdocument/ev-document-attachments.h:55: Warning: XreaderDocument: ev_document_attachments_get_attachments: return value: Missing (element-type) annotation
../xreader-3.8.2/libdocument/ev-document-find.h:63: Warning: XreaderDocument: ev_document_find_find_text: return value: Missing (element-type) annotation
../xreader-3.8.2/libdocument/ev-link-action.h:58: Warning: XreaderDocument: ev_link_action_get_dest: return value: Missing (transfer) annotation
../xreader-3.8.2/libdocument/ev-link-action.h:63: Warning: XreaderDocument: ev_link_action_get_show_list: return value: Missing (element-type) annotation
../xreader-3.8.2/libdocument/ev-link-action.h:64: Warning: XreaderDocument: ev_link_action_get_hide_list: return value: Missing (element-type) annotation
../xreader-3.8.2/libdocument/ev-link-action.h:65: Warning: XreaderDocument: ev_link_action_get_toggle_list: return value: Missing (element-type) annotation
../xreader-3.8.2/libdocument/ev-link-action.h:74: Warning: XreaderDocument: ev_link_action_new_layers_state: argument show_list: Missing (element-type) annotation
../xreader-3.8.2/libdocument/ev-link-action.h:74: Warning: XreaderDocument: ev_link_action_new_layers_state: argument hide_list: Missing (element-type) annotation
../xreader-3.8.2/libdocument/ev-link-action.h:74: Warning: XreaderDocument: ev_link_action_new_layers_state: argument toggle_list: Missing (element-type) annotation
../xreader-3.8.2/libdocument/ev-link.h:50: Warning: XreaderDocument: ev_link_get_action: return value: Missing (transfer) annotation
../xreader-3.8.2/libdocument/ev-document-forms.h:88: Warning: XreaderDocument: ev_document_forms_get_form_fields: return value: Invalid non-constant return of bare structure or union; register as boxed type or (skip)
../xreader-3.8.2/libdocument/ev-image.h:60: Warning: XreaderDocument: ev_image_get_pixbuf: return value: Missing (transfer) annotation
../xreader-3.8.2/libdocument/ev-document-images.h:58: Warning: XreaderDocument: ev_document_images_get_image_mapping: return value: Invalid non-constant return of bare structure or union; register as boxed type or (skip)
../xreader-3.8.2/libdocument/ev-document-images.h:60: Warning: XreaderDocument: ev_document_images_get_image: return value: Missing (transfer) annotation
../xreader-3.8.2/libdocument/ev-document-layers.h:75: Warning: XreaderDocument: ev_document_layers_get_layers: return value: Missing (transfer) annotation
../xreader-3.8.2/libdocument/ev-document-links.h:76: Warning: XreaderDocument: ev_document_links_get_links_model: return value: Missing (transfer) annotation
../xreader-3.8.2/libdocument/ev-document-links.h:78: Warning: XreaderDocument: ev_document_links_get_links: return value: Invalid non-constant return of bare structure or union; register as boxed type or (skip)
../xreader-3.8.2/libdocument/ev-document-links.h:80: Warning: XreaderDocument: ev_document_links_find_link_dest: return value: Missing (transfer) annotation
../xreader-3.8.2/libdocument/ev-document-thumbnails.h:59: Warning: XreaderDocument: ev_document_thumbnails_get_thumbnail: return value: Missing (transfer) annotation
../xreader-3.8.2/libdocument/ev-document-transition.h:59: Warning: XreaderDocument: ev_document_transition_get_effect: return value: Missing (transfer) annotation
[356/361] Generating libdocument/XreaderDocument-1.5.typelib with a custom command
../xreader-3.8.2/backend/dvi/mdvi-lib/util.c: In function ‘mdvi_build_path_from_cwd’:
../xreader-3.8.2/backend/dvi/mdvi-lib/util.c:341:9: warning: ‘__builtin_strncat’ specified bound depends on the length of the source argument [-Wstringop-overflow=]
341 | strncat (buf, path, strlen (path));
| ^
../xreader-3.8.2/backend/dvi/mdvi-lib/util.c:341:9: note: length computed here
341 | strncat (buf, path, strlen (path));
| ^
[357/361] Generating libview/XreaderView-1.5.gir with a custom command (wrapped by meson to set env)
[358/361] Generating symbol file libview/libxreaderview.so.3.0.0.p/libxreaderview.so.3.0.0.symbols
[359/361] Linking target shell/xreader
[360/361] Linking target previewer/xreader-previewer
samu: job failed: cc -o shell/xreader shell/xreader.p/main.c.o -flto -Wl,--as-needed -Wl,--no-undefined -pie -Wl,--whole-archive -Wl,--start-group shell/libshell.a -Wl,--no-whole-archive -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now,-fuse-ld=mold -flto=auto -march=native -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -flto=auto -D_FORTIFY_SOURCE=2 '-Wl,-rpath,$ORIGIN/../libview:$ORIGIN/../libdocument' -Wl,-rpath-link,/tmp/makepkg/xreader/src/build/libview -Wl,-rpath-link,/tmp/makepkg/xreader/src/build/libdocument libview/libxreaderview.so.3.0.0 libdocument/libxreaderdocument.so.3.0.0 /usr/lib/libgio-2.0.so /usr/lib/libgobject-2.0.so /usr/lib/libglib-2.0.so /usr/lib/libgtk-3.so /usr/lib/libgdk-3.so /usr/lib/libz.so /usr/lib/libpangocairo-1.0.so /usr/lib/libpango-1.0.so /usr/lib/libharfbuzz.so /usr/lib/libatk-1.0.so /usr/lib/libcairo-gobject.so /usr/lib/libcairo.so /usr/lib/libgdk_pixbuf-2.0.so /usr/lib/libsecret-1.so -lm /usr/lib/libxapp.so -Wl,--end-group
mold: error: undefined symbol: IceAddConnectionWatch
>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(sm_client_xsmp_startup)
mold: error: undefined symbol: SmcSetErrorHandler
>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(sm_client_xsmp_startup)
mold: error: undefined symbol: IceSetIOErrorHandler
>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(sm_client_xsmp_startup)
mold: error: undefined symbol: XLockDisplay
>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(screensaver_enable_x11.lto_priv.0)>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(screensaver_disable_x11.lto_priv.0)
mold: error: undefined symbol: SmcSetProperties
>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(set_properties)
mold: error: undefined symbol: XSetScreenSaver
>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(screensaver_enable_x11.lto_priv.0)>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(screensaver_disable_x11.lto_priv.0)
mold: error: undefined symbol: IceProcessMessages
>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(process_ice_messages)
mold: error: undefined symbol: SmcInteractDone
>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(xsmp_interact)>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(sm_client_xsmp_will_quit)>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(sm_client_xsmp_will_quit)
mold: error: undefined symbol: IceConnectionNumber
>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(ice_connection_watch)
mold: error: undefined symbol: XUnlockDisplay
>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(screensaver_enable_x11.lto_priv.0)>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(screensaver_disable_x11.lto_priv.0)
mold: error: undefined symbol: SmcInteractRequest
>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(do_save_yourself)
mold: error: undefined symbol: IceSetErrorHandler
>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(sm_client_xsmp_startup)
mold: error: undefined symbol: SmcOpenConnection
>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(sm_client_xsmp_startup)
mold: error: undefined symbol: SmcDeleteProperties
>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(delete_properties)
mold: error: undefined symbol: SmcCloseConnection
>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(xsmp_die)>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(process_ice_messages)
mold: error: undefined symbol: SmcGetIceConnection
>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(sm_client_xsmp_end_session)
mold: error: undefined symbol: IceGetConnectionContext
>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(process_ice_messages)
mold: error: undefined symbol: XGetScreenSaver
>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(screensaver_disable_x11.lto_priv.0)
mold: error: undefined symbol: SmcVendor
>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(sm_client_xsmp_end_session)
mold: error: undefined symbol: SmcRequestSaveYourself
>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(sm_client_xsmp_end_session)
mold: error: undefined symbol: SmcSaveYourselfDone
>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(xsmp_shutdown_cancelled)>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(xsmp_interact)>>> referenced by <artificial>
>>> /tmp/cc6oDrfL.ltrans0.ltrans.o:(sm_client_xsmp_will_quit)>>> referenced 3 more times

collect2: error: ld returned 1 exit status
In file included from /usr/include/bits/libc-header-start.h:33,
from /usr/include/limits.h:26,
from /usr/lib/gcc/x86_64-pc-linux-gnu/13.1.1/include/limits.h:205,
from /usr/lib/gcc/x86_64-pc-linux-gnu/13.1.1/include/syslimits.h:7,
from /usr/lib/gcc/x86_64-pc-linux-gnu/13.1.1/include/limits.h:34,
from /usr/lib/glib-2.0/include/glibconfig.h:11,
from /usr/include/glib-2.0/glib/gtypes.h:34,
from /usr/include/glib-2.0/glib/galloca.h:34,
from /usr/include/glib-2.0/glib.h:32,
from /usr/include/glib-2.0/gobject/gbinding.h:30,
from /usr/include/glib-2.0/glib-object.h:24,
from /tmp/makepkg/xreader/src/xreader-3.8.2/libview/ev-document-model.h:27,
from /tmp/makepkg/xreader/src/build/g-ir-cpp-ffgdctqt.c:4:
/usr/include/features.h:413:4: warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp]
413 | # warning _FORTIFY_SOURCE requires compiling with optimization (-O)
| ^~~~~~~
../xreader-3.8.2/libview/ev-document-model.h:74: Warning: XreaderView: symbol='xreader_web_document_set_inverted_colors': Unknown namespace for symbol 'xreader_web_document_set_inverted_colors'
../xreader-3.8.2/libview/ev-job-scheduler.h:45: Warning: XreaderView: ev_job_scheduler_get_running_thread_job: return value: Missing (transfer) annotation
../xreader-3.8.2/libview/ev-jobs.h:492: Warning: XreaderView: ev_job_find_get_results: return value: Missing (element-type) annotation
../xreader-3.8.2/libview/ev-print-operation.h:51: Warning: XreaderView: ev_print_operation_get_print_settings: return value: Missing (transfer) annotation
../xreader-3.8.2/libview/ev-print-operation.h:54: Warning: XreaderView: ev_print_operation_get_default_page_setup: return value: Missing (transfer) annotation
../xreader-3.8.2/libview/ev-view.h:78: Warning: XreaderView: ev_view_find_changed: argument results: Missing (element-type) annotation
samu: subcommand failed
==> ERROR: A failure occurred in build().
Aborting...
This task depends upon

Closed by  Antonio Rojas (arojas)
Saturday, 05 August 2023, 07:57 GMT
Reason for closing:  Fixed
Additional comments about closing:  9cda3ec
Comment by Antonio Rojas (arojas) - Wednesday, 26 July 2023, 07:32 GMT
@heftig this is caused by the meson 1.2 update, any ideas?
Comment by Jan Alexander Steffens (heftig) - Wednesday, 26 July 2023, 15:55 GMT
They're using link_whole all over the place, which doesn't carry dependencies properly, so LTO breaks the build.

https://pkgbuild.com/~heftig/xreader.diff should fix it.
Comment by Link (Extension-Prompt-440) - Thursday, 27 July 2023, 21:35 GMT
@heftig Maybe I'm doing this wrong but the patch *did* allow the compilation to complete (still got the errors but I guess they were ignored?) but when I go to run the program after installing the build I get this error:
ERROR:../xreader-3.8.2/shell/ev-window.c:7699:ev_window_init: assertion failed (error == NULL): The resource at “/org/x/reader/shell/ui/xreader.xml” does not exist (g-resource-error-quark, 0)
Bail out! ERROR:../xreader-3.8.2/shell/ev-window.c:7699:ev_window_init: assertion failed (error == NULL): The resource at “/org/x/reader/shell/ui/xreader.xml” does not exist (g-resource-error-quark, 0)
Aborted (core dumped)
Comment by Toolybird (Toolybird) - Thursday, 27 July 2023, 21:47 GMT Comment by Jan Alexander Steffens (heftig) - Saturday, 29 July 2023, 21:33 GMT
I've updated the patch to use `link_whole` for the one dependency (on libshell) where this seems to matter, since GResource digs through the symbol table at runtime and we need to ensure the unused-at-link-time gresources are not skipped.
Comment by Link (Extension-Prompt-440) - Monday, 31 July 2023, 22:19 GMT
@heftig Tried the new patch, compilation+install succeeded & no errors from the program when ran from the command line.
I'm new to this, what needs to happen for the PKGBUILD to work automatically again?
Does upstream have to do anything about this or is the patch all that is needed?

Loading...