Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#78922 - lapce 0.2.8-1 breaks remote development feature

Attached to Project: Arch Linux
Opened by Tobias (holzgeist) - Thursday, 29 June 2023, 11:32 GMT
Last edited by Caleb Maclennan (alerque) - Tuesday, 04 July 2023, 19:54 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Leonidas Spyropoulos (inglor)
Caleb Maclennan (alerque)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
Since Lapce v0.2.8 (specifically since https://github.com/lapce/lapce/pull/2374), the lapce build scripts rely on the version to be in env var RELEASE_TAG_NAME. And starting with https://github.com/lapce/lapce/commit/a6fc783e19c37a35e7a95a6241dd26ca75b80b2d (not in a release yet), it will stop using CARGO_PKG_VERSION at all.

The compiled in version of lapce is used by the remote server to download a binary from github. Without RELEASE_TAG_NAME being set, the reported version is "Nightly", which (at least currently) uses an incompatible protocol to communicate with the local machine, therefore breaking remote development.

The fix is to set RELEASE_TAG_NAME=v$pkgver in PKGBUILD. I just added an export in the build function which works, but I'm not sure if there's a more elegant way of doing that.

Additional info:
* it started with v0.2.8, as this is the first release with PR #2374 merged
* Log file showing output of remote shell script:

```
[2023-06-29][13:24:41][lapce_data::proxy::upload_file][DEBUG] + tmp_dir=/tmp
+ lapce_new_ver=nightly
+ eval lapce_dir='/home/tobias/.local/share/lapce-nightly/proxy'
+ lapce_dir=/home/tobias/.local/share/lapce-nightly/proxy
+ [ -e /home/tobias/.local/share/lapce-nightly/proxy/lapce ]
+ chmod +x /home/tobias/.local/share/lapce-nightly/proxy/lapce
+ /home/tobias/.local/share/lapce-nightly/proxy/lapce --version
+ cut -dv -f2
+ lapce_installed_ver=Lapce-proxy nightly-5c15d84
+ printf [DEBUG]: Current proxy version: %s\n Lapce-proxy nightly-5c15d84
+ printf [DEBUG]: New proxy version: %s\n nightly
+ [ Lapce-proxy nightly-5c15d84 = nightly ]
+ printf Proxy outdated. Replacing proxy\n
+ rm /home/tobias/.local/share/lapce-nightly/proxy/lapce
+ test_cmd tar
+ command -v tar
+ test_cmd gzip
+ command -v gzip
+ test_cmd uname
+ command -v uname
+ uname -s
+ os_name=linux
+ uname -m
+ arch_name=x86_64
+ printf Switching to "%s"\n /tmp
+ cd /tmp
+ lapce_download_url=https://github.com/lapce/lapce/releases/download/nightly/lapce-proxy-linux-x86_64.gz
+ test_cmd curl
+ command -v curl
+ printf Downloading using curl\n
+ curl --proto =https --tlsv1.2 -LfS -O https://github.com/lapce/lapce/releases/download/nightly/lapce-proxy-linux-x86_64.gz
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0

100 7036k 100 7036k 0 0 8069k 0 --:--:-- --:--:-- --:--:-- 8069k
+ printf Creating "%s"\n /home/tobias/.local/share/lapce-nightly/proxy
+ mkdir -p /home/tobias/.local/share/lapce-nightly/proxy
+ printf Decompressing gzip\n
+ gzip -d /tmp/lapce-proxy-linux-x86_64.gz
+ printf Moving proxy to our dir\n
+ mv -v /tmp/lapce-proxy-linux-x86_64 /home/tobias/.local/share/lapce-nightly/proxy/lapce
+ printf Making it executable\n
+ chmod +x /home/tobias/.local/share/lapce-nightly/proxy/lapce
+ printf lapce-proxy installed\n
+ exit 0

[2023-06-29][13:24:41][lapce_data::proxy::upload_file][DEBUG] [DEBUG]: Current proxy version: Lapce-proxy nightly-5c15d84
[DEBUG]: New proxy version: nightly
Proxy outdated. Replacing proxy
Switching to "/tmp"
Downloading using curl
Creating "/home/tobias/.local/share/lapce-nightly/proxy"
Decompressing gzip
Moving proxy to our dir
renamed '/tmp/lapce-proxy-linux-x86_64' -> '/home/tobias/.local/share/lapce-nightly/proxy/lapce'
Making it executable
lapce-proxy installed

[2023-06-29][13:24:41][lapce_data::proxy::start_remote][DEBUG] remote proxy path: ~/.local/share/lapce-nightly/proxy
[2023-06-29][13:24:41][lapce_data::proxy::start_remote][DEBUG] process id: 44151
```

Steps to reproduce:

* Launch lapce
* connect to remote host
* wait for shell to appear (but it doesn't)
This task depends upon

Closed by  Caleb Maclennan (alerque)
Tuesday, 04 July 2023, 19:54 GMT
Reason for closing:  Fixed
Additional comments about closing:  0.2.8-2

Loading...