Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#78853 - [gitlab] lfs import service may fail due to unhandled exception

Attached to Project: Arch Linux
Opened by loqs (loqs) - Wednesday, 21 June 2023, 16:05 GMT
Last edited by Caleb Maclennan (alerque) - Thursday, 22 June 2023, 08:04 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Anatol Pomozov (anatolik)
Caleb Maclennan (alerque)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
Upstream issues [1][3]. gitlab fixed the issue [2] by handling the exception to prevent Sidekiq from dying. The fix does not apply cleanly as parts of it are for code only in the enterprise edition. The first hunk which is the only required one for FOSS edition could be filtered out.
gitlab have proposed a fix for the grpc gem [4] that can be applied cleanly. It has not yet been merged.
Attached diff [5] patches the grpc gem. [6] Updates the fix for 16.1.0.

Additional info:
* gitlab 16.0.5-1
[1] https://gitlab.com/gitlab-org/gitlab/-/issues/414003
[2] https://gitlab.com/gitlab-org/gitlab/-/commit/26e96344fc1c955c7c18379a91c03f63c52d2abc
[3] https://github.com/grpc/grpc/issues/33283
[4] https://github.com/grpc/grpc/pull/33408/commits/ffd057b399c1f68d43a68b960dd9bdf7a29fdd09
[5] PKGBUILD.diff
[6] PKGBUILD.16.1.0.diff
This task depends upon

Closed by  Caleb Maclennan (alerque)
Thursday, 22 June 2023, 08:04 GMT
Reason for closing:  Fixed
Comment by Caleb Maclennan (alerque) - Thursday, 22 June 2023, 08:02 GMT
Thanks as always for the research and patches. I've applied this to 16.0.5 and posted it to [extra]. The 16.1.0 builds will be along shortly in [extra-testing].
Comment by Caleb Maclennan (alerque) - Thursday, 22 June 2023, 08:04 GMT
Also to ease the process of patching do feel free to fork the packaging repos on GitLab: https://gitlab.archlinux.org/archlinux/packaging/packages/gitlab

We still don't have the MR feature enabled but if you drop links to your commits in here you won't need to attach patch files and I can cherry pick them directly.

Loading...