FS#78635 - [waybar] Enable experimental features for wlr/workspaces module

Attached to Project: Community Packages
Opened by q rty (q234rty) - Sunday, 28 May 2023, 19:43 GMT
Last edited by Maxim Baz (maximbaz) - Tuesday, 30 May 2023, 21:13 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To Brett Cornwall (ainola)
Maxim Baz (maximbaz)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

See https://github.com/Alexays/Waybar/blob/0.9.17/meson.build#L322-L324 and https://github.com/Alexays/Waybar/blob/0.9.17/src/factory.cpp#L51-L54

This is would enable dropping waybar-hyprland packages from AUR once the fix for https://github.com/hyprwm/Hyprland/issues/2084 makes it into a release.
This task depends upon

Closed by  Maxim Baz (maximbaz)
Tuesday, 30 May 2023, 21:13 GMT
Reason for closing:  Implemented
Additional comments about closing:  Done in 0.9.18-2 (currently in extra-testing, as 0.9.18-1 was there)
Comment by Brett Cornwall (ainola) - Monday, 29 May 2023, 17:12 GMT
maxim, I would decline this as I've no interest in supporting potentially unstable features. When Waybar says it's ready is when it should be included. Thoughts?
Comment by Maxim Baz (maximbaz) - Monday, 29 May 2023, 21:17 GMT
I have a few reasons why I'd actually wouldn't mind enabling it, let me share them with you, and if you still prefer to decline, then let us decline :)

1. This is the only experimental feature in waybar:
https://github.com/Alexays/Waybar/blob/3c2fa1625d1fc0c7399219ef1ba2af771b5d0bf6/src/factory.cpp#L33-L37

2. It has already been marked experimental since November 2021, without much changes on waybar side since that time:
https://github.com/Alexays/Waybar/commit/3c2fa1625d1fc0c7399219ef1ba2af771b5d0bf6

3. It's experimental because the protocol itself is not merged yet (looks like there is recent activity though):
https://github.com/Alexays/Waybar/issues/1766
https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/40

4. I am personally using locally a custom build of waybar with this experimental flag enabled, as I am using Hyprland lately, so I will be able to spot if this ever breaks.

Let me know what you think!
Comment by Brett Cornwall (ainola) - Monday, 29 May 2023, 23:00 GMT
My hesitance is to enable any experimental modules - regardless of whether there's only one right now. I like to think of Arch as the latest of what's considered stable and push the bleeding edge onto the AUR.

If you think it would add value to the users of [extra], though, do feel free to enable it!
Comment by Maxim Baz (maximbaz) - Tuesday, 30 May 2023, 13:52 GMT
Understood! I do think it's valuable, will enable it today :)

By saying that there's only one experimental flag, I only meant to say that the impact is limited to only one additional module, which I will be constantly testing. Furthermore, in this particular case of waybar, I feel like the "experimental" flag indicates not that waybar itself has something they are not confident about, but that the contract between waybar and hyprland (in this case) is not finalized, and has a chance to be changed (even though it hadn't been in the past two years) - which waybar and/or hyprland will have to treat like any other bug.

Thanks for the feedback!

Loading...