FS#77720 - [ruby-sinatra] broken by rack 3.x

Attached to Project: Community Packages
Opened by Felix Yan (felixonmars) - Saturday, 04 March 2023, 10:34 GMT
Last edited by Buggy McBugFace (bugbot) - Saturday, 25 November 2023, 20:05 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Andreas Schleifer (Segaja)
Felix Yan (felixonmars)
Tim (bastelfreak)
Architecture All
Severity High
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

> require 'sinatra'
/usr/lib/ruby/gems/3.0.0/gems/sinatra-2.2.2/lib/sinatra/base.rb:1809:in `<class:Base>': uninitialized constant Rack::Session (NameError)
Did you mean? Rack::RACK_SESSION
from /usr/lib/ruby/gems/3.0.0/gems/sinatra-2.2.2/lib/sinatra/base.rb:918:in `<module:Sinatra>'
from /usr/lib/ruby/gems/3.0.0/gems/sinatra-2.2.2/lib/sinatra/base.rb:22:in `<top (required)>'
from <internal:/usr/lib/ruby/3.0.0/rubygems/core_ext/kernel_require.rb>:85:in `require'
from <internal:/usr/lib/ruby/3.0.0/rubygems/core_ext/kernel_require.rb>:85:in `require'
from /usr/lib/ruby/gems/3.0.0/gems/sinatra-2.2.2/lib/sinatra/main.rb:26:in `<module:Sinatra>'
from /usr/lib/ruby/gems/3.0.0/gems/sinatra-2.2.2/lib/sinatra/main.rb:1:in `<top (required)>'
from <internal:/usr/lib/ruby/3.0.0/rubygems/core_ext/kernel_require.rb>:85:in `require'
from <internal:/usr/lib/ruby/3.0.0/rubygems/core_ext/kernel_require.rb>:85:in `require'
from /usr/lib/ruby/gems/3.0.0/gems/sinatra-2.2.2/lib/sinatra.rb:1:in `<top (required)>'
from <internal:/usr/lib/ruby/3.0.0/rubygems/core_ext/kernel_require.rb>:160:in `require'
from <internal:/usr/lib/ruby/3.0.0/rubygems/core_ext/kernel_require.rb>:160:in `rescue in require'
from <internal:/usr/lib/ruby/3.0.0/rubygems/core_ext/kernel_require.rb>:149:in `require'
from (irb):1:in `<main>'
from /usr/lib/ruby/gems/3.0.0/gems/irb-1.4.2/exe/irb:11:in `<top (required)>'
from /usr/bin/irb:25:in `load'
from /usr/bin/irb:25:in `<main>'
<internal:/usr/lib/ruby/3.0.0/rubygems/core_ext/kernel_require.rb>:85:in `require': cannot load such file -- sinatra (LoadError)
from <internal:/usr/lib/ruby/3.0.0/rubygems/core_ext/kernel_require.rb>:85:in `require'
from (irb):1:in `<main>'
from /usr/lib/ruby/gems/3.0.0/gems/irb-1.4.2/exe/irb:11:in `<top (required)>'
from /usr/bin/irb:25:in `load'
from /usr/bin/irb:25:in `<main>'

Upstream draft PR: https://github.com/sinatra/sinatra/pull/1857
This task depends upon

Closed by  Buggy McBugFace (bugbot)
Saturday, 25 November 2023, 20:05 GMT
Reason for closing:  Moved
Additional comments about closing:  https://gitlab.archlinux.org/archlinux/p ackaging/packages/ruby-sinatra/issues/1
Comment by loqs (loqs) - Sunday, 09 April 2023, 20:49 GMT
New required packages [1][2]. Updated rack to 3.0.7 [3]. Updated sinatra to 3.0.5 and applied commits from upstream to apply proposed PR [4]. Refactor sinatra [5]. [6] is not for packaging, it is just to test sinatra-contrib.

[1] PKGBUILD.ruby-rackup
[2] PKGBUILD.ruby-rack-session
[3] PKGBUILD.diff.ruby-rack
[4] PKGBUILD.diff.ruby-sinatra.1
[5] PKGBUILD.diff.ruby-sinatra.2
[6] PKGBUILD.diff.ruby-sinatra.3
   PKGBUILD.ruby-rackup (1.5 KiB)
   PKGBUILD.ruby-rack-session (1.5 KiB)
   PKGBUILD.diff.ruby-rack (2.7 KiB)
   PKGBUILD.diff.ruby-sinatra.1 (128 KiB)
   PKGBUILD.diff.ruby-sinatra.2 (5.5 KiB)
   PKGBUILD.diff.ruby-sinatra.3 (2 KiB)
Comment by loqs (loqs) - Friday, 14 April 2023, 19:44 GMT
Updated ruby-sinatra diffs [1][2][3] for the sinatra 3.0.6 release which reduces the size of the patch by half.
I forgot to mention previously I dropped [4] from the PR as the change it addresses has been reverted in rack 3.0.7, this is covered in the upstream PR conversation [5].

[1] PKGBUILD.diff.ruby-sinatra.1
[2] PKGBUILD.diff.ruby-sinatra.2
[3] PKGBUILD.diff.ruby-sinatra.3
[4] https://github.com/sinatra/sinatra/pull/1857/commits/952cd464f71e53db2aeb83632e9086e0ce476ca2
[5] https://github.com/sinatra/sinatra/pull/1857
   PKGBUILD.diff.ruby-sinatra.1 (62.3 KiB)
   PKGBUILD.diff.ruby-sinatra.2 (5.5 KiB)
   PKGBUILD.diff.ruby-sinatra.3 (2 KiB)
Comment by loqs (loqs) - Sunday, 16 April 2023, 20:47 GMT
Updated ruby-sinatra diffs [1][2] to include other changes from the sinatra 3 release. Removed ruby-sass [3], SASS support may be reintroduced using sass-embedded in the future [4]. Removed ruby-maruku [5]. Added ruby-falcon to commented out additional packages for integration testing [6]

[1] PKGBUILD.diff.ruby-sinatra.1
[2] PKGBUILD.diff.ruby-sinatra.2
[3] https://github.com/sinatra/sinatra/commit/b4f61f59cf8f938db261a6561a69ca61d01e8581
[4] https://github.com/sinatra/sinatra/pull/1911
[5] https://github.com/sinatra/sinatra/commit/3538518b61f1b4c20d22720af889cbdd0e77367f
[6] https://github.com/sinatra/sinatra/commit/cb7361714a56a717fea8dc5211f6c4e048b31991
   PKGBUILD.diff.ruby-sinatra.1 (62.6 KiB)
   PKGBUILD.diff.ruby-sinatra.2 (5.5 KiB)
Comment by loqs (loqs) - Thursday, 28 September 2023, 12:02 GMT
Added the suggested changes to gitlab for easier review [1][2][3].

[1] https://gitlab.archlinux.org/loqs/ruby-rack/-/commits/update/
[2] https://gitlab.archlinux.org/loqs/ruby-rackup
[3] https://gitlab.archlinux.org/loqs/ruby-sinatra/-/commits/update/

Loading...