FS#77687 - [transmission-qt] No application icon

Attached to Project: Arch Linux
Opened by Yannick (Spike29) - Wednesday, 01 March 2023, 10:37 GMT
Last edited by Buggy McBugFace (bugbot) - Saturday, 25 November 2023, 20:18 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Florian Pritz (bluewind)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:
transmission-qt doesn't provide an application icon, unlike transmission-gtk.

Additional info:
* transmission-qt 4.0.1-2
This task depends upon

Closed by  Buggy McBugFace (bugbot)
Saturday, 25 November 2023, 20:18 GMT
Reason for closing:  Moved
Additional comments about closing:  https://gitlab.archlinux.org/archlinux/p ackaging/packages/transmission/issues/1
Comment by Toolybird (Toolybird) - Thursday, 02 March 2023, 04:10 GMT
Related  FS#48530 
Comment by loqs (loqs) - Thursday, 02 March 2023, 23:03 GMT
If you install transmission-gtk does transmission-qt use the icons provided by transmission-gtk? Meaning they would just need to be moved from transmission-gtk to a common dependency.
Comment by Yannick (Spike29) - Friday, 03 March 2023, 10:28 GMT
Yes, transmission-qt uses the same icon as transmission-gtk after installing the latter package.
Comment by loqs (loqs) - Sunday, 05 March 2023, 19:54 GMT
Please try rebuilding with the attached diff. It does the following:
Make libtransmission supply a shared library and have all other components use it and depend libtransmission.
Add cmake component names to items that will not be installed to transmission-cli so cmake --install build --component $foo can be used
Move icons to libtransmission.
Temporarily disable USE_SYSTEM_DHT as libdht.a is not built with -fPIC or -fpic so can not be linked into a shared library.
This approach also avoids packaging private headers.
   PKGBUILD.diff (11.2 KiB)
Comment by Yannick (Spike29) - Sunday, 19 March 2023, 15:03 GMT
Sorry for the late reply.
I applied the diff and tried to rebuild the transmission package with makepkg -s.

Unfortunately the build fails. Here is the output: https://pastebin.com/EtFiFu3e
Comment by loqs (loqs) - Sunday, 19 March 2023, 17:08 GMT
I can not reproduce that build failure. The build currently fails due to [1]. I added a work around for that issue and updated the pkgver to 4.0.2. See attached diff.
Instead of using makepkg please try extra-x86_64-build provided by the devtools package, which will build the package in a clean chroot [2].

[1] https://github.com/transmission/transmission/issues/5258
[2] https://wiki.archlinux.org/title/DeveloperWiki:Building_in_a_clean_chroot
   PKGBUILD.diff (11.6 KiB)
Comment by Yannick (Spike29) - Sunday, 19 March 2023, 17:33 GMT
Thanks, the build was successful with extra-x86_64-build from the devtools package.

I confirm that the Transmission icon is displayed correctly with both transmission-qt 4.0.2 and libtransmission 4.0.2 packages installed.
Comment by Florian Pritz (bluewind) - Sunday, 26 March 2023, 16:07 GMT
This patch is a bit too big for my taste for inclusion just on our side. There's also an open bug for this upstream so I'd suggest you try submitting the patch there: https://github.com/transmission/transmission/issues/5173
Comment by loqs (loqs) - Sunday, 26 March 2023, 16:48 GMT
> This patch is a bit too big for my taste for inclusion just on our side.There's also an open bug for this upstream so I'd suggest you try submitting the patch there: https://github.com/transmission/transmission/issues/5173
The addition of install targets can be addressed after upstream has addressed the qt icon installation issue. As you noted the patch is too large and unspecific for 5173 as it also addresses the other issues I listed previously. So I will leave it to you to submit a targeted patch.

Do you want me to open new issues for the installation of private headers and the missing shared library?

Loading...