FS#77573 - [sane] Accidental rename of saned@.service to saned.service

Attached to Project: Arch Linux
Opened by ibbem (ibbem) - Sunday, 19 February 2023, 14:24 GMT
Last edited by David Runge (dvzrv) - Saturday, 25 February 2023, 21:43 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To David Runge (dvzrv)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 2
Private No

Details

Description:
The systemd service file `saned.socket` includes the directive `Accept=yes` which requires a service *template* according to `man systemd.socket`. This was included in the arch repository as `saned@.service` until 66335c59c742b0118977344bebc0a2d1a43875a6 (git-svn-id: file:///srv/repos/svn-packages/svn@408211 eb2447ed-0c53-47e4-bac8-5bc4a241df78) which renamed it to `saned.service`
> because svn is silly and has issues with @ in file names
but still installed it as `saned@.service` during `package()`.

Later, in commit 15b259fbd01818f2f3f02bb40cf49f4285e09a6e (git-svn-id: file:///srv/repos/svn-packages/svn@468287 eb2447ed-0c53-47e4-bac8-5bc4a241df78) there was a refactoring which did miss the different install name and caused the service to be installed as `saned.service` instead of `saned@.service`.

Additional info:
* sane version: 1.2.1-3

Steps to reproduce:
systemctl enable saned.socket
echo test | nc localhost 6566

Expected behavior:
The system shouldn't degrade. (No additional service should be in the failed state).

Actual behavior:
The `saned.socket` fails with the following log messages:
> saned.socket: Failed to queue service startup job (Maybe the service file is missing or not a template unit?): Invalid argument
> saned.socket: Failed with result 'resources'.
This task depends upon

Closed by  David Runge (dvzrv)
Saturday, 25 February 2023, 21:43 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed with sane 1.2.1-4
Comment by Agustín Cisneros (aerz) - Saturday, 25 February 2023, 19:39 GMT
Today I had the same problem configuring SANE and I was came to the same conclusion. The saned.service should be saned@.service to allow remote connections.
It can be fixed just renaming /usr/lib/systemd/system/saned.service to /usr/lib/systemd/system/saned@.service
I confirm the issue.
Comment by David Runge (dvzrv) - Saturday, 25 February 2023, 21:43 GMT
@ibbem: Thanks for the report! I have fixed this in a pkgrel bump.

Loading...