FS#77558 - [ko] fish completions are malformed

Attached to Project: Community Packages
Opened by Narthana Epa (trigtriarius) - Saturday, 18 February 2023, 01:31 GMT
Last edited by Buggy McBugFace (bugbot) - Saturday, 25 November 2023, 20:05 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Christian Rebischke (Shibumi)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
The completions file for fish, `/usr/share/fish/vendor_completions.d/ko.fish`, is not parsable by fish. It contains the output of the help for the `ko completion` command rather than the output of the `ko completion fish` command.

This is because in https://github.com/archlinux/svntogit-community/blob/packages/ko/trunk/PKGBUILD#L41, the completion file is written to the contents of `./ko completion completion fish` instead of `./ko completion fish`.

It may be an upstream issue that `ko completion completion fish` outputs to stdout and exits with code 0 instead of stderr and a non-zero exit code, but solving that would not fix the PKGBUILD.

Additional info:
* package version: ko 0.12.0-3

Steps to reproduce:
1. Type ko into a fish prompt
2. Press tab to invoke autocomplete
This task depends upon

Closed by  Buggy McBugFace (bugbot)
Saturday, 25 November 2023, 20:05 GMT
Reason for closing:  Moved
Additional comments about closing:  https://gitlab.archlinux.org/archlinux/p ackaging/packages/ko/issues/1

Loading...