FS#77439 - [beets] plugin web attachment_filename should be renamed download_name

Attached to Project: Community Packages
Opened by Ossewaarde (Tjaco) - Wednesday, 08 February 2023, 20:27 GMT
Last edited by Buggy McBugFace (bugbot) - Saturday, 25 November 2023, 20:05 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Maxime Gauduin (Alucryd)
Bruno Pagani (ArchangeGabriel)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description: Using beets beet web plugin:
TypeError: send_file() got an unexpected keyword argument 'attachment_filename'

Additional info:
* package version(s): 1.6.0-4

Steps to reproduce:
Start beet web on server and browse to server.ip:8337
Error message will appear on screen of server; sound and download does not work in browser

The explanation is that attachment_filename have been renamed download_name in python.
File: "/usr/lib/python3.10/site-packages/beetsplug/web/__init__.py"
Line 327: attachment_filename=safe_filename
Should be
download_name=safe_filename

See also: https://github.com/beetbox/beets/blob/master/beetsplug/web/__init__.py
This task depends upon

Closed by  Buggy McBugFace (bugbot)
Saturday, 25 November 2023, 20:05 GMT
Reason for closing:  Moved
Additional comments about closing:  https://gitlab.archlinux.org/archlinux/p ackaging/packages/beets/issues/1

Loading...