FS#77303 - [electron] libappindicator-gtk3 is no longer needed

Attached to Project: Community Packages
Opened by Rocket Aaron (rocket1184) - Sunday, 29 January 2023, 02:49 GMT
Last edited by Buggy McBugFace (bugbot) - Saturday, 25 November 2023, 20:05 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Caleb Maclennan (alerque)
Bruno Pagani (ArchangeGabriel)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:

Since Electron 22, upstream decided to remove GtkStatusIcon based tray, and move to chromium's StatusIconLinuxDbus implementation, which "is sending raw dbus messages" and does not require libappindicator.

I've tested Electron 22.0.3 on KDE Plasma 5.25.6 and the SNI tray icon works fine without libappindicator-gtk3

Additional info:
* package version(s)
- electron 22.0.3-1
* config and/or log files etc.
* link to upstream bug report, if any
- Related Issue: https://github.com/electron/electron/issues/36283
- Related PR: https://github.com/electron/electron/pull/36333

Steps to reproduce:
This task depends upon

Closed by  Buggy McBugFace (bugbot)
Saturday, 25 November 2023, 20:05 GMT
Reason for closing:  Moved
Additional comments about closing:  https://gitlab.archlinux.org/archlinux/p ackaging/packages/electron/issues/2
Comment by Caleb Maclennan (alerque) - Thursday, 18 May 2023, 19:24 GMT
I'll fix this just as soon as we get *any* Electron builds actually building again. Thanks for the report and references.
Comment by loqs (loqs) - Thursday, 25 May 2023, 19:11 GMT
Attached diff updates electron to 24.3.1 and adds patches so it builds with gcc 13. Build tested only.
Edit:
patches without a link are from the chromium PKGBUILD. patches with -v2 suffix have been modified to apply.
   PKGBUILD.diff (44.6 KiB)
Comment by loqs (loqs) - Saturday, 27 May 2023, 21:46 GMT
Attached diff updates electron to 22.3.11 needed slightly more patches than 24.3.1 to build with gcc 13. Needed two custom patches and changes to two existing patches.
   PKGBUILD.diff (42.3 KiB)
Comment by loqs (loqs) - Sunday, 28 May 2023, 02:31 GMT
Corrected diff for 22.3.11 the previous one was missing some of the patches.
   PKGBUILD.diff (45.9 KiB)
Comment by Caleb Maclennan (alerque) - Wednesday, 14 June 2023, 07:59 GMT
As usual thanks immensely for the research, links, and patches. I think all of 22, 23, 24, an 25 have this issue addressed now. Still working on getting the rolling latest bare `electron` package bumped to the 25 one but that is unrelated to this issue and involves Arch tooling problems.
Comment by prettyvanilla (prettyvanilla) - Wednesday, 28 June 2023, 22:12 GMT
electron22 and electron23 packages still list libappindicator-gtk3 as an optional dependency. If I'm reading things correctly these also had the fixes backported and removing the optdep was actually intended there as well?

Loading...