FS#77232 - [php-legacy-fpm] adopt changes php-fpm-legacy to php-legacy-fpm
Attached to Project:
Arch Linux
Opened by Andreas Radke (AndyRTR) - Sunday, 22 January 2023, 17:10 GMT
Last edited by Pierre Schmitz (Pierre) - Sunday, 19 February 2023, 09:06 GMT
Opened by Andreas Radke (AndyRTR) - Sunday, 22 January 2023, 17:10 GMT
Last edited by Pierre Schmitz (Pierre) - Sunday, 19 February 2023, 09:06 GMT
|
Details
Following the legacy naming scheme the paths in the pkg
should be fixed as well:
https://wiki.archlinux.org/index.php?title=Nextcloud&oldid=764680 in /usr/lib/tmpfiles.d/php-legacy-fpm.conf it should be fixed: d /run/php-fpm-legacy 755 root root to d /run/php-legacy-fpm 755 root root Or the naming scheme in the wiki page should be reverted. |
This task depends upon
I guess there are two options
* Follow our php-legacy-* naming scheme and rename binaries and config if needed
* Follow PHP's naming scheme, rename all the packages and always add "-legacy" to the end: php-fpm-legacy, php-gd-legacy.
This should affect binaries in php-legacy-fpm and php-legacy-cgi.
Any preferences? I tend towards solutions #1 as I find it less confusing; but I'd go with either.
Inconsistent file names:
php-legacy-8.1.14-3-x86_64: usr/share/man/man1/php-config-legacy.1.gz
php-legacy-8.1.14-3-x86_64: usr/bin/php-config-legacy
php-legacy-cgi-8.1.14-3-x86_64: usr/share/man/man1/php-cgi-legacy.1.gz
php-legacy-cgi-8.1.14-3-x86_64: usr/bin/php-cgi-legacy
php-legacy-fpm-8.1.14-3-x86_64: usr/share/man/man8/php-fpm-legacy.8.gz
php-legacy-fpm-8.1.14-3-x86_64: usr/bin/php-fpm-legacy
Inconsistent content (binary files excluded):
php-legacy-fpm-8.1.14-3-x86_64: etc/php-legacy/php-fpm.conf: ;pid = /run/php-fpm-legacy/php-fpm.pid
php-legacy-fpm-8.1.14-3-x86_64: etc/php-legacy/php-fpm.d/www.conf: listen = /run/php-fpm-legacy/php-fpm.sock
php-legacy-fpm-8.1.14-3-x86_64: usr/lib/tmpfiles.d/php-legacy-fpm.conf: d /run/php-fpm-legacy 755 root root
php-legacy-fpm-8.1.14-3-x86_64: usr/lib/systemd/system/php-legacy-fpm.service: PIDFile=/run/php-fpm-legacy/php-fpm.pid
php-legacy-fpm-8.1.14-3-x86_64: usr/lib/systemd/system/php-legacy-fpm.service: ExecStart=/usr/bin/php-fpm-legacy --nodaemonize --fpm-config /etc/php-legacy/php-fpm.conf
php-legacy-8.1.14-3-x86_64: usr/lib/php-legacy/build/phpize.m4: [php-config-legacy],
No that much - IMHO.
What I was going for was replacing all occurrences of php with php-legacy. ./configure even seems to have an option to accomplish this "--program-transform-name='s/php/php-legacy/'". Even though this is advertised, it sadly does not work: https://github.com/php/php-src/pull/3996
Binaries like phpize or phar are good examples where this approach would fail and is probably one of the reasons why the PHP devs settled with a simple suffix.
With 8.1.14-4 I matched the service name to the binary.
I have check packages for Alpine and Debian/Ubuntu. They are all consistently inconsistent in the same way: The package php-$suffix-fpm contains the binary php-fpm-$suffix.
/usr/lib/systemd/system/php-fpm-legacy.service
/usr/lib/systemd/system/php-legacy-fpm.service -> php-fpm-legacy.service
I added the symlink to not break installs made with the privious package.