FS#77121 - [python-qasync] change qt5-python-bindings to opt deps, because qasync can run in qt6 now

Attached to Project: Community Packages
Opened by Bruce Zhang (bruceutut) - Saturday, 14 January 2023, 07:50 GMT
Last edited by Felix Yan (felixonmars) - Friday, 27 January 2023, 15:43 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To Felix Yan (felixonmars)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
according to link below [1], qasync package now support qt5 and qt6 (pyside2, pyqt5, pyside6, pyqt6), maybe this package should opt deps on qt5.

Additional info:
* [1] https://github.com/CabbageDevelopment/qasync/blob/88b64c7eeb94993869a83cdbb0dcb86b107d83d3/qasync/__init__.py#L41
This task depends upon

Closed by  Felix Yan (felixonmars)
Friday, 27 January 2023, 15:43 GMT
Reason for closing:  Implemented
Additional comments about closing:  0.23.0-2
Comment by Toolybird (Toolybird) - Saturday, 14 January 2023, 22:09 GMT
It's true that qt6 support exists, but I'm unsure if optdeps is the correct solution here..
Comment by Felix Yan (felixonmars) - Sunday, 15 January 2023, 04:30 GMT
The only rdep in our repos (feeluown) currently depends on pyqt5 directly.

If I understand it correctly, this library expects the application to choose a python Qt library and intends to work alongside it. I think optdeps here should be fine.

Loading...