FS#77104 - [tftp-hpa] Included .socket is ineffective

Attached to Project: Arch Linux
Opened by Mantas Mikulėnas (grawity) - Thursday, 12 January 2023, 18:27 GMT
Last edited by Buggy McBugFace (bugbot) - Saturday, 25 November 2023, 20:17 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Anatol Pomozov (anatolik)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

extra/tftp-hpa 5.2-10 includes a systemd .socket file for inetd-style activation, but doesn't include a corresponding .service file that would accept such activation. The only .service that's included is a "standalone daemon" configuration with the --listen option, and is even listed as conflicting with the .socket unit. Trying to use the .socket just makes TFTP requests hang as the daemon isn't configured to accept the inherited socket.

For the .socket file to be useful, a different .service (e.g. tftpd-inetd.service) is needed with these differences:

5. No "After=network.target"
1. No "Type=forking".
2. No "--listen" option for in.tftpd.
3. Add the [Service] "StandardInput=socket" option.
4. No "WantedBy=".

The .socket unit then should be changed to explicitly request [Socket] "Service=tftpd-inetd.service".
This task depends upon

Closed by  Buggy McBugFace (bugbot)
Saturday, 25 November 2023, 20:17 GMT
Reason for closing:  Moved
Additional comments about closing:  https://gitlab.archlinux.org/archlinux/p ackaging/packages/tftp-hpa/issues/2
Comment by Mantas Mikulėnas (grawity) - Thursday, 12 January 2023, 18:27 GMT
(Realistically, removing the .socket entirely would probably be acceptable for most users.)
Comment by Anatol Pomozov (anatolik) - Friday, 13 January 2023, 20:47 GMT
It might be a fine idea to remove the *.socket file and inetd-style activation.

With this idea in mind, what would be the best way to update the *.service file and use normal service activation? I haven't used this package for a while, so I am looking for help with cleaning this file.
Comment by Mantas Mikulėnas (grawity) - Friday, 13 January 2023, 21:17 GMT
The .service unit is already set up for normal daemon startup (which is why the .socket unit can't work with it).

Loading...