FS#76796 - [libplacebo] Shaders is not applied on output with vo=gpu-next

Attached to Project: Arch Linux
Opened by Aviana Cruz (AvianaCruz) - Saturday, 10 December 2022, 17:03 GMT
Last edited by Toolybird (Toolybird) - Friday, 15 September 2023, 23:02 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Levente Polyak (anthraxx)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
When playing videos with shaders on mpv, the video output remains the same as when not applying the shaders.
My config sets vo to gpu-next with gpu-context=x11vk and gpu-api=vulkan.
The problem exists in both 4.208.0-1 and 5.229.1-1.
I build mpv with the latest git source. And when building libplacebo with the latest git source, the problem disappears.

I did a bisect, and git showed https://github.com/haasn/libplacebo/commit/81d64969d34cfe6b676569a276a77684771276a7, which seems a commit that fixed previous commits which is not included in `v5.229.1`, so there is probably no easy patches. I am wondering whether we can find the necessary commits and backport them.
This task depends upon

Closed by  Toolybird (Toolybird)
Friday, 15 September 2023, 23:02 GMT
Reason for closing:  Fixed
Additional comments about closing:  libplacebo 5.264.1-1
Comment by Toolybird (Toolybird) - Saturday, 10 December 2022, 23:49 GMT
> I am wondering whether we can find the necessary commits and backport them.

It's up to you to find this stuff out before reporting it as a "bug". This ticket comes across as a plea for help which is therefore more suited to the support channels (forum/IRC/etc). vo=gpu-next seems kinda experimental after looking at the "known issues" [1]

[1] https://github.com/mpv-player/mpv/wiki/GPU-Next-vs-GPU
Comment by Aviana Cruz (AvianaCruz) - Sunday, 11 December 2022, 13:17 GMT
My previous given commit is actually to fix a bug that was introduced in the new commits. Then I skipped some commits and figured out that it is https://code.videolan.org/videolan/libplacebo/-/commit/33ded0c18b204d546b91d6d1e36e9b0b6feb23d5 that solved the problem.
The commit cleanly applies on `v5.229.1`.

Loading...